Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #6.
I'm leaving this as a draft for now, since there are a couple choices I made that might need to be validated before a review is in order. And parts of the code need to be fixed (some of it is just indentation issues, discussed below).
To make testing the UI/UX changes a little easier, I've set up the current version and new version on a dev box (hope you don't mind me hosting them, I'll tear them down once the PR is merged). The poll rate has been dropped
1000ms
on the host view to make animation overlap more frequent.debounced: https://new.ghassanachi.com/
current: https://old.ghassanachi.com/
The backend is running in
debug/local
mode, so you can use thesecret
endpoint.debounced_secret: https://new.ghassanachi.com/event/00000000-0000-0000-0000-000000000000/secret
current_secret: https://old.ghassanachi.com/event/00000000-0000-0000-0000-000000000000/secret
Questions
client
code. With different editor setups, i've had to turn off lsp formatting and manually indent things, which doesn't always work with whitespace because of different tab-size settings). Adding a formatter for the client should resolve the issue and guarantee consistency across machines.derived
store, which seems to work well, but I wanted to check that we are okay with this change?transitions
in addition to theanimate
directive. Let me know what you think or if we should remove them? (Currently they are just there for UI/UX, but we could use the "on:outroend" event to drive the redraw code, instead of the fixesanimationTime
value I set up.