-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and develop against Dynamodb Local #179
Conversation
This is great, thank you! |
It's my pleasure actually. I am wondering if the issues section is up-to-date, or some feature requests/issues are missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issues list should be up to date! At least I don't recall any other features I've wanted to be added since.
One thought: now that we have local dynamo, maybe we could make CI run the tests as well? Ideally one day we also have tests of the frontend, but at least running cargo test
would be a start 🎉
Oh, I suppose there is also bringing #10 over the line |
Thank you! |
AWS_DEFAULT_REGION=us-east-1 \ | ||
AWS_ACCESS_KEY_ID=lorem \ | ||
AWS_SECRET_ACCESS_KEY=ipsum \ | ||
AWS_ENDPOINT_URL=http://localhost:8000 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set it up so that there's just one environment variable to set (like USE_DYNAMODB=test
), and when it's set like that then we set the others accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #179 broke release builds by making it necessary for `LiveAskQuestion` and `SEED` to both now be available regardless of whether `debug_assertions` is set. That's unfortunate, since `SEED` in particular would make the binary quite large. So I've instead made it so that in release mode (or rather, without `debug_assertions`), `SEED` is _not_ compiled in, and DynamoDB mode is _always_ used. I've also added a CI job to check `--release --target aarch64-unknown-linux-gnu` so that this can't happen in the future.
PR #179 broke release builds by making it necessary for `LiveAskQuestion` and `SEED` to both now be available regardless of whether `debug_assertions` is set. That's unfortunate, since `SEED` in particular would make the binary quite large. So I've instead made it so that in release mode (or rather, without `debug_assertions`), `SEED` is _not_ compiled in, and DynamoDB mode is _always_ used. I've also added a CI job to check `--release --target aarch64-unknown-linux-gnu` so that this can't happen in the future.
This allow for running e2e tests and developing against a local copy of DynamoDB with the ability to view changes in the admin panel: