Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VM_NAME variable to confd #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions qemu.confd
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
# suitable for you, then you can omit that variable in your VM config.
#

# Name of virtual machine, by default /etc/conf.d/qemu.<VM_NAME>
# Enable when you change variables containing it.
#VM_NAME="${RC_SVCNAME#qemu.}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work, VM_NAME is not declared to be overridable from the confd file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does work for me, just tested this right now. By default VM_NAME variable is empty in confd file.

https://asciinema.org/a/bEWBPLCG12FiXhx5KRgJk50Lc video proof


# User to run the QEMU process.
#user="qemu"
Expand Down