add VM_NAME variable to confd #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirutka
reviewed
Feb 17, 2021
| @@ -16,6 +16,9 @@ | |||
| # suitable for you, then you can omit that variable in your VM config. | |||
| # | |||
|
|
|||
| # Name of virtual machine, by default /etc/conf.d/qemu.<VM_NAME> | |||
| # Enable when you change variables containing it. | |||
| #VM_NAME="${RC_SVCNAME#qemu.}" | |||
There was a problem hiding this comment.
This will not work, VM_NAME is not declared to be overridable from the confd file.
There was a problem hiding this comment.
This does work for me, just tested this right now. By default VM_NAME variable is empty in confd file.
https://asciinema.org/a/bEWBPLCG12FiXhx5KRgJk50Lc video proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might have worked in the past, but now variables specified in initd are empty in confd.