Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rimraf with native rm #297

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Replace rimraf with native rm #297

merged 10 commits into from
Nov 4, 2024

Commits on Nov 3, 2024

  1. refactor: replace rimraf with rm 

    We should check if this regresses anything on Windows before merging.
    @lishaduck
    lishaduck committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    95393f3 View commit details
    Browse the repository at this point in the history

  2. chore: remove rimraf dependabot ignore

    @lishaduck
    lishaduck committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    73e5137 View commit details
    Browse the repository at this point in the history

  3. fix: lint error

    @lishaduck
    lishaduck committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    7acd992 View commit details
    Browse the repository at this point in the history

  4. fix: default FS.remove to recursive

    @lishaduck
    lishaduck committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    cd44c27 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. fix: signature for remove

    @lishaduck
    lishaduck committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    a0bc003 View commit details
    Browse the repository at this point in the history

  2. refactor: use File type 

    A type mismatch pointed out that this wrote out the whole type.
    @lishaduck
    lishaduck committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    e0469e6 View commit details
    Browse the repository at this point in the history

  3. fix: inference 

    This was erroring, not sure why, but the new version certainly reads better.
    @lishaduck
    lishaduck committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    698dcf0 View commit details
    Browse the repository at this point in the history

  4. fix: lint

    @lishaduck
    lishaduck committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    72995fe View commit details
    Browse the repository at this point in the history

  5. fix: use rimraf-native's options 

    Rimraf defaults to `force: true` and has 10 retries.
    @lishaduck
    lishaduck committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    146b94a View commit details
    Browse the repository at this point in the history

  6. refactor: slip another one in 

    With async-await,
we can more clearly show that you send the info either way,
only awaiting the promise is guarded.
    @lishaduck
    lishaduck committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ed4cfa2 View commit details
    Browse the repository at this point in the history