Replace rimraf with native rm
#297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Also, the test failure looks legit. |
We should check if this regresses anything on Windows before merging.
jfmengels
reviewed
Nov 3, 2024
A type mismatch pointed out that this wrote out the whole type.
This was erroring, not sure why, but the new version certainly reads better.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Rimraf defaults to `force: true` and has 10 retries.
With async-await, we can more clearly show that you send the info either way, only awaiting the promise is guarded.
jfmengels
reviewed
Nov 4, 2024
|
Thanks! One less dependency! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check if this regresses anything on Windows before merging.