Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a report of commits and releases to update-since-todo.sh #5278

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

daniel-beck
Copy link
Member

This makes the replacements by the tool more easily reviewable. Modeled after the PR message in #5276 but not bothering to determine PRs (can rather easily be done manually).

Sample output corresponding to #5276:

List of commits introducing new API and the first release they went in:
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.253
  - https://github.com/jenkinsci/jenkins/commit/9b0d18aba319ba6a7c548a06a92435775553948d
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.257
  - https://github.com/jenkinsci/jenkins/commit/5b1dd72d9b7f295c23f19dd21a8827de519be6d8
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.258
  - https://github.com/jenkinsci/jenkins/commit/702bd3921c553e70cdb11aff53370be8c7eeceb1
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.259
  - https://github.com/jenkinsci/jenkins/commit/ded319294049f773455d752526e7984dee00b026
  - https://github.com/jenkinsci/jenkins/commit/3992a30efb1abf697cae8e02f9e81dd04b92b135
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.260
  - https://github.com/jenkinsci/jenkins/commit/eb0876cdb981a83c9f4c6f07d1eede585614612a
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.265
  - https://github.com/jenkinsci/jenkins/commit/b40f70e3d868b5bd41bada18aa23955822521e33
  - https://github.com/jenkinsci/jenkins/commit/9c256ad8305db82e7186b7687e3300a8115a2d10
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.266
  - https://github.com/jenkinsci/jenkins/commit/a9ca5ef3d4c97937636bf3c585f4232514279b14
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.267
  - https://github.com/jenkinsci/jenkins/commit/bd59971eac813f4bc8471d6c2646334a0b704105
  - https://github.com/jenkinsci/jenkins/commit/15cfddf2a77b9fce3cc48cd0fec055b593eb6493
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.272
  - https://github.com/jenkinsci/jenkins/commit/9f50735a8b0f73e9ef73bdabfb1dcefaad55f4f2
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.275
  - https://github.com/jenkinsci/jenkins/commit/71d2ecf1a4e5303e80815eaa3935c4f2fa3d9104
  - https://github.com/jenkinsci/jenkins/commit/b1ca2849660798fd0f7fe8fda8e372cfb2ded621
* https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.279
  - https://github.com/jenkinsci/jenkins/commit/44e11f66bc59150e48835410ac7462b61371f9a3

Or, rendered as Markdown in a pull request:

List of commits introducing new API and the first release they went in:

Proposed changelog entries

n/a

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck daniel-beck added the skip-changelog Should not be shown in the changelog label Feb 10, 2021
@daniel-beck daniel-beck requested a review from batmat February 10, 2021 15:24
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works great! Kudos!

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@timja timja merged commit b32a59c into jenkinsci:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants