-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add at-since annotations up to 2.279 #5276
Conversation
@@ -124,7 +124,7 @@ public SetupWizard() { | |||
* | |||
* If you do not provide any value to that system property, the default admin account will not have an API Token. | |||
* | |||
* @since TODO (for the existence of the sysprop, not the availability to plugin) | |||
* @since 2.260 (with NoExternalUse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rephrased this one because it seemed ambiguous/unclear to me as it was before.
@@ -3903,7 +3903,7 @@ public synchronized HttpRedirect doQuietDown() { | |||
* | |||
* @param block Block until the system really quiets down and no builds are running | |||
* @param timeout If non-zero, only block up to the specified number of milliseconds | |||
* @deprecated since TODO; use {@link #doQuietDown(boolean, int, String)} instead. | |||
* @deprecated since 2.267; use {@link #doQuietDown(boolean, int, String)} instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't generally note when something was deprecated, but it was in the original so I just filled in the version.
@@ -29,7 +29,7 @@ | |||
/** | |||
* Contains information about the token and the secret value. | |||
* It should not be stored as is, but just displayed once to the user and then forget about it. | |||
* @since TODO | |||
* @since This was added in 2.260 but marked NoExternalUse, opened as Beta in 2.265 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was unclear to me which of the version numbers is relevant here, so went into more detail for clarity.
Thanks Daniel! Out of curiosity, did you use the |
@batmat I've been a happy long-time user of your script 😉 I used it to identify locations and insert versions. I then manually looked up the commits and PRs to be able to reference them. A deduplicated list of commit URLs written to stdout (any competent shell has one-click URL opening) would be a very useful addition, PRs are trivial to get from there. Looking at commits also helps ensure the generated versions are correct (#5276 (comment) would not have been). If you want to be fancy, group by version number. |
Implemented in #5278 |
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
This notes additions from the following pull requests or commits:
CloudState
to be passed toCloud#provision
andCloud#canProvision
methods. #4922Proposed changelog entries
(Irrelevant)
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).