Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft to use the joomla core module techniques #1813

Closed
wants to merge 3 commits into from

Conversation

reilldesign
Copy link
Contributor

To be able to select mod_jem overrides (layouts) via dropdown.

Change of entity names to get a more elegant navigation control for the calendar.
in layout com_jem view-event

the icon buttons (.buttons) are not clickable and masked by h1.componentheading
To be able to select mod_jem overrides  (layouts) via dropdown.
@mckillo
Copy link
Collaborator

mckillo commented Aug 21, 2024

In the lastest version 4.2.3 (dev in github):

  • The calendar icons (navigation controls) were changed to Font Awesome icons.
  • The issue with the masked icon couldn't be reproduced, and this commit adds a unnecessary line (space on top).
  • A draft to improve the layout in modules could be addressed by module override,

On the last point, there is a lot of code improvement in JEM, so this should be kept in mind for future versions and JEM should be updated to support the Joomla 6 core and to facilitate the creation of new layouts in JEM (low priority).

@reilldesign
Copy link
Contributor Author

An override is indeed possible. But how can I create different overrides if I can't choose the layout?

@mckillo
Copy link
Collaborator

mckillo commented Aug 21, 2024

I agree. If you need more layouts, an override will be a solution if you want to modify one of them (default, responsive).

Please provide a description of a real case and an example of a layout, so we can evaluate it. Thank you for your expertise and ideas to improve JEM.

The layout is defined as a global setting, and the component and modules display the style based on this setting. Currently, JEM has two layouts and could potentially have more, but adding them would require further code changes.

I have tested the necessary changes and can create new layouts for the JEM modules, but I still need to finish testing.

@reilldesign
Copy link
Contributor Author

Joomla Overrides are a very powerful way to change design and functions. I currently use a mod_jem override to pass event dates to a form (booking). For me it is not important that there are different layouts in the core, but that I can make full use of the override possibilities that the Joomla core provides. The core should only have a clean responsive layout to simplify maintenance.

@mckillo
Copy link
Collaborator

mckillo commented Oct 24, 2024

image

Tested and it works.

If the JEM module uses the layout module, then the JEM module is independent of the Global Layout settings. Each module can have a different layout in its advanced module settings.

This way, the admin has more flexibility to choose the module's layout, including making it easier to create a new layout.

image

This opens up possibilities...

Should we change all JEM modules to use the layout settings in the module?

mckillo added a commit that referenced this pull request Oct 24, 2024
First module with layouts in the module, add example of table layout.
mckillo added a commit that referenced this pull request Oct 24, 2024
First module with layouts in the module, add example of table layout.
mckillo added a commit that referenced this pull request Oct 25, 2024
First module with layouts in the module, add example of table layout.
@mckillo
Copy link
Collaborator

mckillo commented Oct 30, 2024

@jojo12 Have you seen the proposed changes for the module? When you have time.

@jojo12
Copy link
Contributor

jojo12 commented Oct 30, 2024

I don't understand this issue.

@mckillo
Copy link
Collaborator

mckillo commented Oct 30, 2024

This is a PR to utilize the Joomla Layout (overrides) in modules.

JEM currently has only two layouts defined in the code: Responsive (in the responsive folder) and Legacy (default).
When you publish a module, all JEM modules use either the responsive or default layout, which is defined in the JEM settings (static).
If JEM has a global setting with 'responsive,' you can't use the default layout (style) in the new JEM basic module.

With the improvements from this PR, administrators gain three benefits:

  1. We can use either the responsive or default layout (by default, it will match the JEM setting).
  2. We can create new layouts for each JEM module by simply copying the PHP file of one of the existing layouts.
  3. We can create a new CSS file for each layout.

This is an example for the basic JEM module, but it can be extended to other JEM modules. I create a new layouts to ilustrate this case. The JEM Basic module is one, but this module has 5 layouts (responsive, legacy and 3 news).

@mckillo
Copy link
Collaborator

mckillo commented Nov 12, 2024

This PR is closed, but there is a issue with change of model to use Joomla layout in the JEM module.

The development for this can be seen in the layout-modules branch and will be included in JEM 4.4.0 once the model is completed for all modules.

@reilldesign, thank you for the idea and contribution; with it, JEM will be better and more flexible in an upcoming version.

More information and tracking of the changes: #1803

@mckillo mckillo closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants