Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module overrides with core ModuleHelper #1803

Open
reilldesign opened this issue Jul 28, 2024 · 6 comments
Open

Module overrides with core ModuleHelper #1803

reilldesign opened this issue Jul 28, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request fixed Have a commit with the solution. Redesign code
Milestone

Comments

@reilldesign
Copy link
Contributor

Currently only two layouts are supported for the mod_jem (legacy & responsive layout). it would be very useful if other overrides were also possible with the help of the Joomla core ModuleHelper.

Old
require(JemHelper::getModuleLayoutPath($mod_name));

New
require ModuleHelper::getLayoutPath('mod_jem', $params->get('layout', 'default'));

@mckillo
Copy link
Collaborator

mckillo commented Aug 2, 2024

You can choose 2 layouts and you can do custom by override a module layout.
Each JEM module searches in these paths and order, for example mod_jem when responsive layouts is active in JEM setting:

/templates/cassiopeia/html/mod_jem/responsive/default.php
/modules/mod_jem/tmpl/responsive/default.php
/templates/cassiopeia/html/mod_jem/default.php
/modules/mod_jem/tmpl/default.php

JEM hasn't Joomla layout, the layouts are internal by global setting, but it's true that it could change to Joomla layout. In that case, there are to change code in several parts of the modules, but it could be viable (tested) to the improvement in low priority. You have to scale it to see the convert /modules/mod_jem/tmpl/responsive/default.php to /modules/mod_jem/tmpl/responsive.php

@Heklaterriol Heklaterriol added the enhancement New feature or request label Aug 5, 2024
@reilldesign
Copy link
Contributor Author

there is a pull request #1813

@mckillo mckillo added this to the JEM 4.3.1 milestone Oct 20, 2024
@mckillo
Copy link
Collaborator

mckillo commented Oct 30, 2024

The fix of this issue is in PR #1813.

@mckillo mckillo added fixed Have a commit with the solution. Redesign code labels Oct 30, 2024
@jojo12
Copy link
Contributor

jojo12 commented Oct 31, 2024

in installed the mod_jem: it's very nice and opens new possibilities! Well done

@mckillo
Copy link
Collaborator

mckillo commented Oct 31, 2024

Then, open this model with Joomla layout in JEM modules.
Should we change all JEM modules to use the layout settings in the module?

@Heklaterriol Heklaterriol modified the milestones: JEM 4.3.1, JEM 4.4.0 Nov 5, 2024
@mckillo
Copy link
Collaborator

mckillo commented Nov 12, 2024

This issue come from #1813

image

This layout model for the module in Joomla needs to be exported to another JEM module. JEM basic module is finished.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Have a commit with the solution. Redesign code
Projects
None yet
Development

No branches or pull requests

4 participants