-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wide Module to have a Horizontal/Vertical option #243
Comments
and we've seen your issue. You do have a good point and would surely take a look at it but as we're with few, things will take time as other things have to altered/fixed too. |
I'm going to look into that. |
I think the solution of this issue is the layout of this module. Check out the branch for it; currently, I'm only developing the basic Jem module, but I plan to expand the model to other modules as well. |
See this issue with the new module model with layouts: #1803. You can see the layouts of JEM basic module in the layouts-in-modules branch. |
Does it make sense to make a vertical version of a module which is declared as wide (=horizontal)? |
Uh! It might be a good idea: consolidate all JEM modules (except calendar) into a single module with layouts. This way the code would be easier to maintain and customize. The code in all modules is very similar. For example, there will be to unify code in one module and move the all css files to media\mod_jem\css Another thing is the migration of modules... The admin will need to redesign the JEM modules (from old to new). This should be discussed in a separate issue or forum post. |
Why not convert Wide into a Horizontal or Vertical module.
add a drop down setting to make the choice. Solve having to upkeep two different modules.
Basically telling it to use the Horizontal or Vertical template. Get rid of the basic. Killing two birds with one stone. I mentioned this in #216
The text was updated successfully, but these errors were encountered: