Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wide Module to have a Horizontal/Vertical option #243

Open
neyworg opened this issue Jul 20, 2013 · 6 comments
Open

Change wide Module to have a Horizontal/Vertical option #243

neyworg opened this issue Jul 20, 2013 · 6 comments
Assignees
Labels
Milestone

Comments

@neyworg
Copy link
Contributor

neyworg commented Jul 20, 2013

Why not convert Wide into a Horizontal or Vertical module.

add a drop down setting to make the choice. Solve having to upkeep two different modules.

Basically telling it to use the Horizontal or Vertical template. Get rid of the basic. Killing two birds with one stone. I mentioned this in #216
wide

@JKoelman
Copy link
Contributor

and we've seen your issue. You do have a good point and would surely take a look at it but as we're with few, things will take time as other things have to altered/fixed too.

@Heklaterriol Heklaterriol added this to the JEM 4.4.0 milestone Nov 11, 2024
@Heklaterriol Heklaterriol self-assigned this Nov 11, 2024
@Heklaterriol
Copy link
Contributor

I'm going to look into that.

@mckillo
Copy link
Collaborator

mckillo commented Nov 12, 2024

I think the solution of this issue is the layout of this module. Check out the branch for it; currently, I'm only developing the basic Jem module, but I plan to expand the model to other modules as well.

@mckillo
Copy link
Collaborator

mckillo commented Nov 12, 2024

See this issue with the new module model with layouts: #1803.
I think that if the JEM wide module is updated with layouts (horizontal -> default, and adding a vertical layout), it should resolve this issue.

You can see the layouts of JEM basic module in the layouts-in-modules branch.

@jojo12
Copy link
Contributor

jojo12 commented Nov 12, 2024

Does it make sense to make a vertical version of a module which is declared as wide (=horizontal)?
Or you create one single module for all with dropdown menue to choose the different module styles (basic, wide, teaser, banner...)?

@mckillo
Copy link
Collaborator

mckillo commented Nov 12, 2024

Uh! It might be a good idea: consolidate all JEM modules (except calendar) into a single module with layouts. This way the code would be easier to maintain and customize. The code in all modules is very similar.

For example, there will be to unify code in one module and move the all css files to media\mod_jem\css

Another thing is the migration of modules... The admin will need to redesign the JEM modules (from old to new). This should be discussed in a separate issue or forum post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants