Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aspect ratio constraint #22

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Added aspect ratio constraint #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6697e45
Fixed aspect ratios
Mar 10, 2017
40befb1
Added aspect ratio boolean to config file
Mar 10, 2017
8071ca7
Merge pull request #1 from SparkMakerspace/master
Mar 10, 2017
238e749
Update composer.json
Mar 10, 2017
d807cab
Renamed src directory
Mar 10, 2017
bb00770
Merge pull request #2 from SparkMakerspace/master
Mar 10, 2017
7eff66f
Update composer.json
Mar 10, 2017
e50ed39
Merge pull request #3 from SparkMakerspace/master
Mar 10, 2017
b32ef53
changed namespace
Mar 10, 2017
3a25183
Merge pull request #4 from SparkMakerspace/master
Mar 10, 2017
163b0ba
last updates for namespaces
Mar 10, 2017
051c79c
Merge pull request #5 from SparkMakerspace/master
Mar 10, 2017
b17fab3
fixed wrong variable name
Mar 10, 2017
747be41
Merge branch 'dev' of github.com:SparkMakerspace/laradrop
Mar 10, 2017
d06e001
Fixed aspect ratios
Mar 10, 2017
2d66867
Merge branch 'master' into dev
Mar 10, 2017
85a4ef0
Merge branch 'dev'
Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Jasekz/Laradrop/Http/Controllers/LaradropController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,16 @@ public function store()

$thumbDims = config('laradrop.thumb_dimensions');
$img = Image::make($tmpStorage . '/' . $movedFileName);
$img->resize($thumbDims['width'], $thumbDims['height']);
if(config('laradrop.thumb_aspect')){
$img->resize($thumbDims['width'], null, function ($constraint) {
$constraint->aspectRatio();
});
}
else
{
$img->resize($thumbDims['width'], $thumbDims['height']);
}

$img->save($tmpStorage . '/_thumb_' . $movedFileName);

// move thumbnail to final location
Expand Down
3 changes: 3 additions & 0 deletions src/Jasekz/Laradrop/config/config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@

// dimensions for thumbnail generator
'thumb_dimensions' => ['width' => env('LARADROP_THUMB_WIDTH', 150), 'height' => env('LARADROP_THUMB_HEIGHT', 150)],

// when true, the thumbnail sizes will be based solely on the width set above
'thumb_aspect' => env('LARADROP_THUMB_ASPECT', true),

// default thumbnail (if one can not be generated)
'default_thumbnail_url' => env('LARADROP_DEFAULT_THUMB', '/vendor/jasekz/laradrop/img/genericThumbs/no-thumb.png'),
Expand Down