Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aspect ratio constraint #22

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Added aspect ratio constraint #22

wants to merge 17 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2017

This should merge properly, I think. Sorry about my last pull request.

@jasekz
Copy link
Owner

jasekz commented Mar 10, 2017

Can you explain what issue you were having and are attempting to fix? Also, I can't merge changes where you're changing the repo name, i.e - "name": "jjfs85/laradrop". If you'd like to do that, you should fork it instead.

@ghost
Copy link
Author

ghost commented Mar 10, 2017

My intended feature addition is a config parameter called thumb_aspect that is a boolean and when it is set to true, the thumbnail generation will maintain the original image's aspect ratio. I admit the the above set of commits look messy, but look at the file comparison between your present dev branch and my pull request, you'll see only two files have changes: the laradropController and the config.php. I've reverted your repo name and namespace changes.

@jasekz
Copy link
Owner

jasekz commented Mar 13, 2017

Ok, thanks. Cool feature, but would you be able to also implement the option to maintain the height? Just in case someone wants to maintain the height instead of width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant