-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added aspect ratio constraint #22
base: dev
Are you sure you want to change the base?
Conversation
Renamed src directory
Update composer.json
changed namespace
last updates for namespaces
Can you explain what issue you were having and are attempting to fix? Also, I can't merge changes where you're changing the repo name, i.e - |
My intended feature addition is a config parameter called thumb_aspect that is a boolean and when it is set to true, the thumbnail generation will maintain the original image's aspect ratio. I admit the the above set of commits look messy, but look at the file comparison between your present dev branch and my pull request, you'll see only two files have changes: the laradropController and the config.php. I've reverted your repo name and namespace changes. |
Ok, thanks. Cool feature, but would you be able to also implement the option to maintain the height? Just in case someone wants to maintain the height instead of width. |
This should merge properly, I think. Sorry about my last pull request.