Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deep dependencies endpoint #6654

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adityachopra29
Copy link
Contributor

@adityachopra29 adityachopra29 commented Feb 2, 2025

Which problem is this PR solving?

Description of the changes

  • Create endpoint api/deep-dependencies for ddg.
  • Adds code for it to server

How was this change tested?

Checklist

@adityachopra29 adityachopra29 requested a review from a team as a code owner February 2, 2025 16:02
@dosubot dosubot bot added the enhancement label Feb 2, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 10.81081% with 33 lines in your changes missing coverage. Please review.

Project coverage is 95.83%. Comparing base (384203d) to head (4c624a3).

Files with missing lines Patch % Lines
cmd/query/app/analytics/http_gateway.go 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6654      +/-   ##
==========================================
- Coverage   96.00%   95.83%   -0.17%     
==========================================
  Files         363      364       +1     
  Lines       20603    20639      +36     
==========================================
  Hits        19780    19780              
- Misses        628      663      +35     
- Partials      195      196       +1     
Flag Coverage Δ
badger_v1 9.82% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-4.x-v1-manual 14.79% <ø> (ø)
cassandra-4.x-v2-auto 1.81% <ø> (ø)
cassandra-4.x-v2-manual 1.81% <ø> (ø)
cassandra-5.x-v1-manual 14.79% <ø> (ø)
cassandra-5.x-v2-auto 1.81% <ø> (ø)
cassandra-5.x-v2-manual 1.81% <ø> (ø)
elasticsearch-6.x-v1 19.12% <ø> (ø)
elasticsearch-7.x-v1 19.20% <ø> (ø)
elasticsearch-8.x-v1 19.37% <ø> (ø)
elasticsearch-8.x-v2 1.82% <ø> (ø)
grpc_v1 10.80% <ø> (ø)
grpc_v2 7.81% <ø> (ø)
kafka-3.x-v1 10.12% <ø> (ø)
kafka-3.x-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (ø)
opensearch-1.x-v1 19.25% <ø> (ø)
opensearch-2.x-v1 19.25% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (ø)
tailsampling-processor 0.48% <ø> (ø)
unittests 94.72% <10.81%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

Please see comments in #6608, the same applies here

@adityachopra29 adityachopra29 force-pushed the add-deep-dependencies-endpoint branch from 8ff02e0 to 0e4d03e Compare February 3, 2025 18:16
@adityachopra29
Copy link
Contributor Author

@yurishkuro the /deep-dependencies url seems to be working, but there are some issues.

  • Actually jaeger-ui tries to find a focalNode (ie focalService and focalOperation), which is chosen from all the operations of the chosen service. Hence there doesnt seem to be a simple way of just hardcoding the deep-dependencies.
    To show the working in the ui, I chose the hotrod example and a specific service (namely driver) to show the rendering.
  • I tried to set a default value for the focalNode as a temporary solution, but the problem remains that the focalService and focalOperation will have to exist for this to work.
REC-20250203235503.mp4
  • As per your suggestion, I changed the backend to /api/deep-dependencies. However, the frontend still looks for the backend data on /analytics/v1/dependencies . So we will need to raise a PR in the ui repo for the same.

Signed-off-by: adityachopra29 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dummy /deep-dependencies endpoint
2 participants