Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
Signed-off-by: adityachopra29 <[email protected]>
  • Loading branch information
adityachopra29 committed Feb 2, 2025
1 parent c032479 commit 8ff02e0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
10 changes: 4 additions & 6 deletions cmd/query/app/analytics/http_gateway.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (
"net/http"

"github.com/gorilla/mux"
"go.uber.org/zap"
"go.opentelemetry.io/otel/trace"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
"go.opentelemetry.io/otel/trace"
"go.uber.org/zap"

"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
)
Expand All @@ -19,7 +19,7 @@ const (
// paramOpsName = ""
// paramServiceName = ""

routeGetDeepDependencies = "/api/deep-dependencies/"
routeGetDeepDependencies = "/api/deep-dependencies/"
)

// HTTPGateway exposes analytics HTTP endpoints.
Expand Down Expand Up @@ -54,7 +54,7 @@ func spanNameHandler(spanName string, handler http.Handler) http.Handler {
})

Check warning on line 54 in cmd/query/app/analytics/http_gateway.go

View check run for this annotation

Codecov / codecov/patch

cmd/query/app/analytics/http_gateway.go#L49-L54

Added lines #L49 - L54 were not covered by tests
}

func (h * HTTPGateway) getDeepDependencies(w http.ResponseWriter, r *http.Request) {
func (h *HTTPGateway) getDeepDependencies(w http.ResponseWriter, r *http.Request) {
dependencies := TDdgPayload{
Dependencies: []TDdgPayloadPath{
{
Expand All @@ -73,8 +73,6 @@ func (h * HTTPGateway) getDeepDependencies(w http.ResponseWriter, r *http.Reques
if err := json.NewEncoder(w).Encode(dependencies); err != nil {
http.Error(w, "Failed to encode response", http.StatusInternalServerError)
}

Check warning on line 75 in cmd/query/app/analytics/http_gateway.go

View check run for this annotation

Codecov / codecov/patch

cmd/query/app/analytics/http_gateway.go#L57-L75

Added lines #L57 - L75 were not covered by tests


}

// Structs that need to be used or created for deep dependencies
Expand Down
4 changes: 4 additions & 0 deletions cmd/query/app/analytics/http_gateway_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0

package analytics
2 changes: 1 addition & 1 deletion cmd/query/app/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ import (
"google.golang.org/grpc/reflection"

"github.com/jaegertracing/jaeger-idl/proto-gen/api_v2"
"github.com/jaegertracing/jaeger/cmd/query/app/apiv3"
"github.com/jaegertracing/jaeger/cmd/query/app/analytics"
"github.com/jaegertracing/jaeger/cmd/query/app/apiv3"
"github.com/jaegertracing/jaeger/cmd/query/app/querysvc"
v2querysvc "github.com/jaegertracing/jaeger/cmd/query/app/querysvc/v2/querysvc"
"github.com/jaegertracing/jaeger/internal/proto/api_v3"
Expand Down

0 comments on commit 8ff02e0

Please sign in to comment.