Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Use OTEL helper instead of tlscfg #6319

Merged
merged 10 commits into from
Dec 12, 2024

Merge branch 'main' into internal-tlscfg

3c86027
Select commit
Loading
Failed to load commit list.
Merged

[admin] Use OTEL helper instead of tlscfg #6319

Merge branch 'main' into internal-tlscfg
3c86027
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2024 in 0s

96.06% (target 95.00%)

View this Pull Request on Codecov

96.06% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.06%. Comparing base (4162f57) to head (3c86027).

Files with missing lines Patch % Lines
cmd/internal/flags/admin.go 81.81% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6319       +/-   ##
===========================================
+ Coverage   49.01%   96.06%   +47.04%     
===========================================
  Files         182      357      +175     
  Lines       11212    20474     +9262     
===========================================
+ Hits         5496    19668    +14172     
+ Misses       5269      616     -4653     
+ Partials      447      190      -257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.