Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Use OTEL helper instead of tlscfg #6319

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
@chahatsagarmain chahatsagarmain requested a review from a team as a code owner December 6, 2024 23:34
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.04%. Comparing base (4162f57) to head (a8af5d7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/internal/flags/admin.go 94.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6319       +/-   ##
===========================================
+ Coverage   49.01%   96.04%   +47.02%     
===========================================
  Files         182      357      +175     
  Lines       11212    20467     +9255     
===========================================
+ Hits         5496    19657    +14161     
+ Misses       5269      619     -4650     
+ Partials      447      191      -256     
Flag Coverage Δ
badger_v1 8.76% <ø> (ø)
badger_v2 1.60% <ø> (ø)
cassandra-4.x-v1-manual 14.73% <ø> (ø)
cassandra-4.x-v2-auto 1.55% <ø> (ø)
cassandra-4.x-v2-manual 1.55% <ø> (ø)
cassandra-5.x-v1-manual 14.73% <ø> (ø)
cassandra-5.x-v2-auto 1.55% <ø> (ø)
cassandra-5.x-v2-manual 1.55% <ø> (ø)
elasticsearch-6.x-v1 18.35% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.44% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.60% <ø> (ø)
elasticsearch-8.x-v2 1.60% <ø> (ø)
grpc_v1 10.25% <ø> (ø)
grpc_v2 7.79% <ø> (ø)
kafka-v1 9.16% <ø> (ø)
kafka-v2 1.60% <ø> (ø)
memory_v2 1.60% <ø> (+<0.01%) ⬆️
opensearch-1.x-v1 18.48% <ø> (ø)
opensearch-2.x-v1 18.47% <ø> (ø)
opensearch-2.x-v2 1.60% <ø> (ø)
tailsampling-processor 0.45% <ø> (ø)
unittests 94.95% <94.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
yurishkuro and others added 3 commits December 11, 2024 21:58
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro enabled auto-merge (squash) December 12, 2024 03:11
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro disabled auto-merge December 12, 2024 03:35
@yurishkuro yurishkuro changed the title [internal] Use OTEL helper instead of tlscfg [admin] Use OTEL helper instead of tlscfg Dec 12, 2024
@yurishkuro yurishkuro merged commit 8696541 into jaegertracing:main Dec 12, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants