Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sync testflight config command #203
base: master
Are you sure you want to change the base?
Implement sync testflight config command #203
Changes from 5 commits
e972651
114d95b
abefab7
53c6436
c59e0eb
2066c54
c298746
6ebab0c
ebdbae0
2a0fe03
41ca74d
2ca5b7a
af0b5d8
bec00a4
a4388f4
d0c1fad
4ef448d
5d36cf9
5be708c
3e4f8fe
92d3dc4
b69901d
c2fe7ff
0e5363c
27f4ebd
47a4b8f
49a5a8e
b8d4f02
e5fca76
8e600f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to filter the pulled apps by bundleId.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the fundamental problem with this command is that you're executing the service requests as you're processing. This should be more functional. Eg:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be printing the results as we execute the commands not after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to support pulling a subset of apps (filtered by bundleIds probably).