Implement sync testflight config command #203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
orj
previously requested changes
Jul 15, 2020
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPullCommand.swift
Outdated
Show resolved
Hide resolved
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPullCommand.swift
Outdated
Show resolved
Hide resolved
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPullCommand.swift
Outdated
Show resolved
Hide resolved
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPushCommand.swift
Outdated
Show resolved
Hide resolved
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPushCommand.swift
Outdated
Show resolved
Hide resolved
Tests/appstoreconnect-cliTests/Sync/SyncTestFlightTestersTests.swift
Outdated
Show resolved
Hide resolved
Tests/appstoreconnect-cliTests/Sync/SyncTestFlightTestersTests.swift
Outdated
Show resolved
Hide resolved
Sources/AppStoreConnectCLI/Services/SyncResourceComparator.swift
Outdated
Show resolved
Hide resolved
DechengMa
force-pushed
the
testflight/sync
branch
from
16abb0f
to
a4388f4
Compare
orj
reviewed
Jul 22, 2020
orj
reviewed
Jul 22, 2020
orj
reviewed
Jul 22, 2020
orj
reviewed
Jul 22, 2020
| try appsFolder.delete() | ||
|
|
||
| try config.forEach { | ||
| let appFolder = try appsFolder.createSubfolder(named: $0.app.bundleId!) |
There was a problem hiding this comment.
Force unwrapping this here seems not ideal. Can an app actually have a nil bundleId? Seems unlikely.
orj
reviewed
Jul 22, 2020
Tests/appstoreconnect-cliTests/Sync/ResourceComparatorCompareGroupsTests.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
Tests/appstoreconnect-cliTests/Sync/ResourceComparatorCompareGroupsTests.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
Tests/appstoreconnect-cliTests/Sync/ResourceComparatorCompareGroupsTests.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPullCommand.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
Sources/AppStoreConnectCLI/Services/AppStoreConnectService.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
| @@ -798,6 +914,54 @@ class AppStoreConnectService { | |||
| .await() | |||
| } | |||
|
|
|||
| func pullTestFlightConfigs() throws -> [TestFlightConfiguration] { | |||
| let apps = try listApps(bundleIds: [], names: [], skus: [], limit: nil) | |||
There was a problem hiding this comment.
We will need to support pulling a subset of apps (filtered by bundleIds probably).
orj
reviewed
Jul 22, 2020
| default: "./config/apps", | ||
| help: "Path to the folder containing the TestFlight configuration." | ||
| ) var outputPath: String | ||
|
|
There was a problem hiding this comment.
We should be able to filter the pulled apps by bundleId.
orj
reviewed
Jul 22, 2020
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPushCommand.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
Sources/AppStoreConnectCLI/Commands/TestFlight/Sync/TestFlightPushCommand.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 22, 2020
| @Flag(help: "Perform a dry run.") | ||
| var dryRun: Bool | ||
|
|
||
| func run() throws { |
There was a problem hiding this comment.
So the fundamental problem with this command is that you're executing the service requests as you're processing. This should be more functional. Eg:
compute(localState, remoteState) -> changeSet
execute(changeSet, isDryRun) -> ()
c103531
to
5be708c
Compare
DechengMa
force-pushed
the
testflight/sync
branch
from
ae25314
to
3e4f8fe
Compare
orj
reviewed
Jul 24, 2020
Sources/AppStoreConnectCLI/Services/AppStoreConnectService.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 24, 2020
Sources/AppStoreConnectCLI/Services/AppStoreConnectService.swift
Outdated
Show resolved
Hide resolved
orj
reviewed
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Sync TestFlight Configuration Command for syncing local and server TestFlight configs.
Support:
📝 Summary of Changes
Changes proposed in this pull request:
TestFlightConfigLoaderandTestFlightConfigurationBetaGroupandBetaTesterin new FileSystem moduleSyncResourceComparatorfor comparing local and server resourcesDue to the number of API calls, the pull config from server command will take a considerable amount of time.
Limitations:
🧐🗒 Reviewer Notes
💁 Example
Usage:
asc testflight sync pull [--output-path <output-path>]asc testflight sync push [--input-path <input-path>] [--dry-run] [--refresh-local]🔨 How To Test
swift run asc testflight sync pullswift run asc testflight sync push --dry-runswift run asc testflight sync push