Remove defaultProps from LoadingIndicator

Partially Resolves jaegertracing#2596 - Updated the LoadingIndicator component to remove defaultProps so as to avoid the deprecation warnings. - Updated the snapshots so as to match the new LoadingIndicator. Signed-off-by: Abhishek <[email protected]>
its-me-abhishek · Jan 20, 2025 · 7390573 · 7390573
1 parent 657cd00
commit 7390573
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 17 deletions.
diff --git a/...eger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap b/...eger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap
@@ -89,9 +89,7 @@ exports[`<SidePanel> render renders detailLink 1`] = `
     className="Ddg--DetailsPanel--LoadingWrapper"
   >
     <LoadingIndicator
-      centered={false}
       className="Ddg--DetailsPanel--LoadingIndicator"
-      small={false}
     />
   </div>
   <VerticalResizer
@@ -268,9 +266,7 @@ exports[`<SidePanel> render renders while loading 1`] = `
     className="Ddg--DetailsPanel--LoadingWrapper"
   >
     <LoadingIndicator
-      centered={false}
       className="Ddg--DetailsPanel--LoadingIndicator"
-      small={false}
     />
   </div>
   <VerticalResizer

diff --git a/...ges/jaeger-ui/src/components/Monitor/ServicesView/__snapshots__/serviceGraph.test.js.snap b/...ges/jaeger-ui/src/components/Monitor/ServicesView/__snapshots__/serviceGraph.test.js.snap
@@ -704,7 +704,6 @@ exports[`<ServiceGraph> Loading indicator is displayed 1`] = `
   >
     <LoadingIndicator
       centered={true}
-      small={false}
     />
   </div>
 </div>
@@ -735,7 +734,6 @@ exports[`<ServiceGraph> Loading indicator is displayed when xDomain is empty 1`]
   >
     <LoadingIndicator
       centered={true}
-      small={false}
     />
   </div>
 </div>

diff --git a/...rc/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap b/...rc/components/Monitor/ServicesView/operationDetailsTable/__snapshots__/index.test.js.snap
@@ -11,7 +11,6 @@ exports[`<OperationTableDetails> "Couldn’t fetch data" displayed 1`] = `
 exports[`<OperationTableDetails> Loading indicator is displayed 1`] = `
 <LoadingIndicator
   centered={true}
-  small={false}
 />
 `;
 

diff --git a/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap b/packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/index.test.js.snap
@@ -44,7 +44,6 @@ exports[`QualityMetrics UnconnectedQualityMetrics render renders when loading 1`
   />
   <LoadingIndicator
     centered={true}
-    small={false}
   />
 </div>
 `;

diff --git a/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx b/packages/jaeger-ui/src/components/common/LoadingIndicator.tsx
@@ -25,20 +25,19 @@ type LoadingIndicatorProps = {
   style?: React.CSSProperties;
 };
 
-export default function LoadingIndicator(props: LoadingIndicatorProps) {
-  const { centered, vcentered, className, small, ...rest } = props;
+export default function LoadingIndicator({
+  centered = false,
+  vcentered,
+  className,
+  small = false,
+  ...rest
+}: LoadingIndicatorProps) {
   const cls = `
     LoadingIndicator
     ${centered ? 'is-centered' : ''}
     ${vcentered ? 'is-vcentered' : ''}
     ${small ? 'is-small' : ''}
-    ${className || ''}
+    ${className}
   `;
   return <LuLoader2 className={cls} {...rest} />;
 }
-
-LoadingIndicator.defaultProps = {
-  centered: false,
-  className: undefined,
-  small: false,
-};
-Original file line number
+Diff line change
@@ Expand Up @@
       />
       <LoadingIndicator
         centered={true}
-        small={false}
       />
     </div>
     `;
@@ Expand Down @@