Skip to content

Commit

Permalink
[Deps]: Remove dependency on redux-form (jaegertracing#2593)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- resolves jaegertracing#2556

## Description of the changes
- This PR removes the redux-form dependency completely.
- The state is now managed with built-in react state management.
- A separate `ValidatedFormField` component is created to handle the
Validated minDuration and maxDuration fields that require validation and
`Popover` to be displayed on failed validations.
- A middle ware was being used to fetch operations based on the selected
service. That middleware was earlier being triggered on selecting a
`redux-form` field, but would now trigger on selecting a new service
from Service Selector.

## How was this change tested?
- npm run test
- npm run start (compared the jaeger-ui 1.65.0 with this PR changes)

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
  • Loading branch information
hari45678 and yurishkuro authored Jan 19, 2025
1 parent 1178b1c commit 657cd00
Show file tree
Hide file tree
Showing 16 changed files with 361 additions and 422 deletions.
53 changes: 0 additions & 53 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/jaeger-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@
"redux": "^4.2.1",
"redux-actions": "2.6.5",
"redux-first-history": "^5.2.0",
"redux-form": "^8.3.10",
"redux-promise-middleware": "^6.1.3",
"store": "^2.0.12",
"ts-key-enum": "^2.0.0",
Expand Down
Loading

0 comments on commit 657cd00

Please sign in to comment.