Skip to content

Conversation

saratpoluri
Copy link

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Jun 17, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested review from benjaminum and ssheorey June 17, 2025 23:31
Copy link
Contributor

@timohl timohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If python/requirements_viz.txt defines the visualization requirements, dash should probably be removed from python/requirements.txt, right?

numpy>=1.18.0
dash>=2.6.0
werkzeug>=3.0.0
flask>=3.0.0
nbformat>=5.7.0
configargparse

Also, it might be good to add a try block to these imports with a nice error message:

from dash import html
from dash import dcc
from dash import Dash

Also, I am not sure if this becomes a problem when dash is removed from requirements.
This imports the plotly functions:

from .draw_plotly import get_plotly_fig
from .draw_plotly import draw_plotly
from .draw_plotly import draw_plotly_server

And this imports it in the main open3d __init__.py:
import open3d.visualization

I would suspect it will cause a missing import error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants