Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FetchContent for both pybind11 and nanobind. #18872

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use FetchContent for both pybind11 and nanobind. #18872

wants to merge 3 commits into from
+21 −28

Commits on Oct 22, 2024

  1. Use FetchContent for both pybind11 and nanobind. 

    This avoids various pinning problems and ensures that the version that IREE specifies at the top of a build is used consistently throughout. The nanobind incantation was taken from shortfin. The pybind11 incantation was adapted from [a comment](pybind/pybind11#2817 (comment)) and extended to use find_package integration.

The latter is sufficient for MLIR's pybind11 finding to delegate to the one set at the top level. The MLIR code for finding pybind11 is ancient and should be modernized to use FetchContent and find_package integration with a pinned version. This would ensure consistent interop with the rest of the ecosystem.

Signed-off-by: Stella Laurenzo <[email protected]>
    @stellaraccident
    stellaraccident committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    755acca View commit details
    Browse the repository at this point in the history

  2. Remove commented code 

    Signed-off-by: Stella Laurenzo <[email protected]>
    @stellaraccident
    stellaraccident committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    cf8339e View commit details
    Browse the repository at this point in the history

  3. Add include 

    Signed-off-by: Stella Laurenzo <[email protected]>
    @stellaraccident
    stellaraccident committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a6d5dfc View commit details
    Browse the repository at this point in the history