Use FetchContent for both pybind11 and nanobind. #18872
Open
+21
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids various pinning problems and ensures that the version that IREE specifies at the top of a build is used consistently throughout. The nanobind incantation was taken from shortfin. The pybind11 incantation was adapted from [a comment](pybind/pybind11#2817 (comment)) and extended to use find_package integration. The latter is sufficient for MLIR's pybind11 finding to delegate to the one set at the top level. The MLIR code for finding pybind11 is ancient and should be modernized to use FetchContent and find_package integration with a pinned version. This would ensure consistent interop with the rest of the ecosystem. Signed-off-by: Stella Laurenzo <[email protected]>
Signed-off-by: Stella Laurenzo <[email protected]>
Signed-off-by: Stella Laurenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids various pinning problems and ensures that the version that IREE specifies at the top of a build is used consistently throughout. The nanobind incantation was taken from shortfin. The pybind11 incantation was adapted from a comment and extended to use find_package integration.
The latter is sufficient for MLIR's pybind11 finding to delegate to the one set at the top level. The MLIR code for finding pybind11 is ancient and should be modernized to use FetchContent and find_package integration with a pinned version. This would ensure consistent interop with the rest of the ecosystem.