Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build dependencies in Release mode #272

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Build dependencies in Release mode #272

merged 1 commit into from
Sep 8, 2023

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Sep 5, 2023

  • Change default CMAKE_BUILD_TYPE from RelWithDebInfo to Release. Compiling with -O3 instead of -O2 gives gRPC a considerable speed boost.

  • Rename cmake_BUILD_TYPE to deps_BUILD_TYPE. The 'cmake_' prefix is reserved.

- Change default CMAKE_BUILD_TYPE from RelWithDebInfo to Release.
  Compiling with -O3 instead of -O2 gives gRPC a considerable
  speed boost.

- Rename cmake_BUILD_TYPE to deps_BUILD_TYPE. The 'cmake_' prefix
  is reserved.

Signed-off-by: Derek G Foster <[email protected]>
@ffoulkes ffoulkes requested review from 5abeel and satish153 September 5, 2023 15:56
@ffoulkes ffoulkes changed the title Change default build type to Release Change default build type of dependencies to Release Sep 5, 2023
@ffoulkes ffoulkes changed the title Change default build type of dependencies to Release Build dependencies in Release mode Sep 5, 2023
Copy link
Collaborator

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit a6cd6cd into main Sep 8, 2023
@ffoulkes ffoulkes deleted the default-build-type branch September 8, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants