Change default build type to Release (#272)

- Change default CMAKE_BUILD_TYPE from RelWithDebInfo to Release.
  Compiling with -O3 instead of -O2 gives gRPC a considerable
  speed boost.

- Rename cmake_BUILD_TYPE to deps_BUILD_TYPE. The 'cmake_' prefix
  is reserved.

Signed-off-by: Derek G Foster <[email protected]>

Author: ffoulkes

setup/CMakeLists.txt

@@ -60,15 +60,22 @@ else()
   list(APPEND CMAKE_PREFIX_PATH ${CMAKE_INSTALL_PREFIX})
 endif()
 
+if(NOT CMAKE_BUILD_TYPE)
+  set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Choose the build type." FORCE)
+endif()
+
+set_property(CACHE CMAKE_BUILD_TYPE PROPERTY STRINGS
+    "Debug;Release;RelWithDebInfo")
+
 if(NOT CMAKE_BUILD_TYPE STREQUAL "")
-    set(cmake_BUILD_TYPE "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}")
+    set(deps_BUILD_TYPE "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}")
 endif()
 
 cmake_print_variables(CMAKE_BUILD_TYPE)
-cmake_print_variables(CMAKE_TOOLCHAIN_FILE)
+cmake_print_variables(CMAKE_FIND_ROOT_PATH)
 cmake_print_variables(CMAKE_INSTALL_PREFIX)
 cmake_print_variables(CMAKE_PREFIX_PATH)
-cmake_print_variables(CMAKE_FIND_ROOT_PATH)
+cmake_print_variables(CMAKE_TOOLCHAIN_FILE)
 
 ##########################
 # Set CMAKE_CXX_STANDARD #
@@ -118,7 +125,7 @@ ExternalProject_Add(abseil-cpp
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/abseil-cpp
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
@@ -149,7 +156,7 @@ ExternalProject_Add(zlib
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/zlib
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
@@ -174,7 +181,7 @@ ExternalProject_Add(cares
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/c-ares
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
@@ -199,7 +206,7 @@ ExternalProject_Add(protobuf
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/protobuf
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_POSITION_INDEPENDENT_CODE=on
@@ -246,7 +253,7 @@ ExternalProject_Add(grpc
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/grpc
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_INSTALL_RPATH=$ORIGIN
@@ -295,7 +302,7 @@ ExternalProject_Add(cctz
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/cctz
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
@@ -322,7 +329,7 @@ ExternalProject_Add(gflags
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/gflags
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
@@ -349,7 +356,7 @@ ExternalProject_Add(glog
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/glog
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
@@ -378,7 +385,7 @@ ExternalProject_Add(gtest
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/gtest
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DCMAKE_INSTALL_RPATH=$ORIGIN
@@ -403,7 +410,7 @@ ExternalProject_Add(json
   SOURCE_DIR
     ${CMAKE_SOURCE_DIR}/json
   CMAKE_ARGS
-    ${cmake_BUILD_TYPE}
+    ${deps_BUILD_TYPE}
     -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TOOLCHAIN_FILE}
     -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
     -DJSON_BuildTests=off