Set recommended compiler flags #249
Conversation
ffoulkes
commented
Aug 11, 2023
ffoulkes
commented
- Set C and C++ compiler flags according to the Intel Secure Coding Standards.
ffoulkes
requested review from
nupuruttarwar,
n-sandeep,
vsureshkumarp and
5abeel
as code owners
|
Unfortunately, throwing in all the compiler flags IPAS recommends makes us incompatible with libraries that aren't built with (some of) the flags we're now specifying. It's going to take a while to figure out which options are causing the problems and find a way to deal with it. I've worked around it for now by adding support for "legacy" legacy -- replicating the settings we used when cross-compiling for ACC. In the meantime, this module is a significant improvement over the existing code. |
|
I don't have access to a system that allows me to verify that the code cross-compiles for ACC. I'm working on solving that problem, but it might be quicker if someone else can test it for me. I have no intention of merging this PR until we've verified that it does not break the ACC build. |
ffoulkes
force-pushed
the
compiler-flags
branch
from
dfba251 to
5761217
Compare
ffoulkes
force-pushed
the
compiler-flags
branch
from
5761217 to
d4a5c14
Compare
- Functions to set C and C++ compiler flags according to the Intel Secure Coding Standards. (squashed) (rebased) Signed-off-by: Derek G Foster <[email protected]>
ffoulkes
force-pushed
the
compiler-flags
branch
from
d4a5c14 to
84d2cd1
Compare
Signed-off-by: Derek G Foster <[email protected]>
