Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMAKE_POSITION_INDEPENDENT_CODE #98

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

ffoulkes
Copy link
Collaborator

@ffoulkes ffoulkes commented Aug 16, 2023

  • Remove local definition of CMAKE_POSITION_INDEPENDENT_CODE. This option is currently the responsibility of the superproject, which is responsible for handling the security settings.

Related to recipe PR #249, but the two do not depend on each other.

- Remove local definition of CMAKE_POSITION_INDEPENDENT_CODE.
  This option is the now responsibility of the superproject,
  which fulfills it by applying the settings defined in
  CompilerSettings.cmake.

Signed-off-by: Derek G Foster <[email protected]>
Copy link
Collaborator

@satish153 satish153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit 9ec4abe into split-arch Sep 8, 2023
@ffoulkes ffoulkes deleted the compiler-settings branch September 8, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants