Skip to content

Requesting for code reviews

Aditya Ekawade edited this page Nov 24, 2020 · 2 revisions

The developer should be precise when requesting code reviews and make sure the requested reviewer spends minimum time and effort in building the project for review. The developer has to link the issue to the Pull request and add a test case for the reviewer in the description.

Example of a test case:

This PR fixes issue #653 and #609

To test:

  • Launch gene.iobio from quarantest.
  • (You will get a warning: Unable to access OMIM, click OK)
  • Select Load your data
  • Select trio and GRcH38
  • Add URL’s and launch
  • Add gene F5
  • Check if all tracks are visible

If the functionality cannot be tested on quarantest, the developer has to specify that the Pull Request needs to be built locally and add the instructions on how to build the project.