Add rescue for JSON::ParserError #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Oj parser v3.3.7+ will throw an Oj::ParseError and (when mimicking json) a JSON::ParserError. MultiJSON assumes that any JSON parser will just throw one specific type of exception, but it seems fair to also rescue any JSON::ParserError thrown while parsing. Solves: voxpupuli/json-schema#399
|
Travis CI retriggered |
|
Okay, these build failures are due to outdated dependencies, not my changes. |
|
I'm not sure why you'd use Oj in mimic-stdlib-JSON mode with Oj adapter vs JsonGem adapter. This seems more like a configuration issue to me, but in any case it's worth addressing I guess. |
|
This should be addressed by 275e3ff |
|
Released 0.13.0 |
|
Thanks! Interesting way to solve this. To the drive-by reader: This is of course fixed in v1.13.0, not in v0.13.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Oj parser v3.3.7+ will throw an Oj::ParseError and
(when mimicking json) a JSON::ParserError.
MultiJSON assumes that any JSON parser will just throw
one specific type of exception, but it seems fair to
also rescue any JSON::ParserError thrown while parsing.
Solves: voxpupuli/json-schema#399