Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oj gem with version 3.3.7 or more #399

Open
Jesterovskiy opened this issue Oct 5, 2017 · 11 comments
Open

Oj gem with version 3.3.7 or more #399

Jesterovskiy opened this issue Oct 5, 2017 · 11 comments

Comments

@Jesterovskiy
Copy link

When I updated Oj gem I get issue:
JSON::ParserError: Empty input at line 1, column 1 [parse.c:926]
This is because in new Oj version, for line https://github.com/ruby-json-schema/json-schema/blob/c12f6000795cc0fdf8d17d97d5bf9c1b383037e4/lib/json-schema/validator.rb#L527 if you send string with path to JSON file for parsing, you get this exception

@mzishtiaq
Copy link

@Jesterovskiy Hey there, did you manage to solve this issue? It looks like there haven't been any updates on this gem for a while. :)

@Jesterovskiy
Copy link
Author

@mzishtiaq gem 'oj', '3.3.6', I don't have time to fix it =(

@leoarnold
Copy link

@Jesterovskiy Let me guess: Your Gemfile.lock contains multi_json, right?

@Jesterovskiy
Copy link
Author

@mzishtiaq ohler55/oj#441 you can start from this issue

@Jesterovskiy
Copy link
Author

@leoarnold yes, you right

@leoarnold
Copy link

Everyone affected: please also read this explanation: ohler55/oj#441 (comment)

@leoarnold
Copy link

There is actually a long history of effort to eliminate the usage of multi_json in json-schema, but sadly it looks like efforts have stalled: #339

@mzishtiaq
Copy link

@leoarnold Thanks for the detailed explanation. That was very helpful indeed.

@leoarnold
Copy link

@Jesterovskiy This might be solved when using multi_json v1.13.0, see intridea/multi_json#183

@mzishtiaq
Copy link

@leoarnold @Jesterovskiy I can confirm that this has solved the problem and it's working now.

@Jesterovskiy
Copy link
Author

Jesterovskiy commented Jan 9, 2018

I'm trying to ping @iainbeeston to merge his PR. I think, that multi-JSON not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants