[NFCI][SYCL] Complete handler::MQueue->handler_impl move
#18767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
force-pushed
the
handler_impl
branch
from
a0ac055 to
1775007
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
handler_impl
branch
from
1775007 to
2c1faf5
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
handler_impl
branch
from
53c9bbd to
9591489
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
handler_impl
branch
from
c578e36 to
df614b1
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
handler_impl
branch
from
e19b9df to
fd4300f
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This comment was marked as resolved.
This comment was marked as resolved.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Jun 9, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -845,11 +832,14 @@ event handler::finalize() { | |||
| #endif | |||
| } | |||
|
|
|||
| // Because graph case is handled right above. | |||
| assert(Queue); | |||
There was a problem hiding this comment.
Would it be better to use sycl::exception here? So, that we can catch exception even when asserts are disabled (release builds)
There was a problem hiding this comment.
No, exception is a recoverable error. Here we'll have a flow in the logic if that ever triggers.
uditagarwal97
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
@aelovikov-intel hi, this PR broke sycl_cts/test_reduction:
/__w/llvm/llvm/toolchain/bin/../include/sycl/handler.hpp:3962:13: error: no matching constructor for initialization of 'handler'
3962 | handler AuxHandler(getSyclObjImpl(Queue), CGH.eventNeeded() || !InOrder);
See: https://github.com/intel/llvm/actions/runs/15549830233/job/43778612663
Could you check please?
|
Looking. Update: reproducible with |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 10, 2025
As a matter of fact, I like this even more, because `type_erased_cgfo_ty` is cheap to create/pass around, we have full access to `handler_impl` in `handler.cpp` (unlike `handler.cpp` where it's opaque) and circular includes/type completeness aren't an issue anymore.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 10, 2025
As a matter of fact, I like this even more, because `type_erased_cgfo_ty` is cheap to create/pass around, we have full access to `handler_impl` in `handler.cpp` (unlike `handler.cpp` where it's opaque) and circular includes/type completeness aren't an issue anymore.
aelovikov-intel
added a commit
that referenced
this pull request
Jun 10, 2025
As a matter of fact, I like this even more, because `type_erased_cgfo_ty` is cheap to create/pass around, we have full access to `handler_impl` in `handler.cpp` (unlike `handler.hpp` where it's opaque) and circular includes/type completeness aren't an issue anymore.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jun 12, 2025
Issues identification/suggested fixes by @Alexandr-Konovalov.
aelovikov-intel
added a commit
that referenced
this pull request
Jun 12, 2025
Issues identification/suggested fixes by @Alexandr-Konovalov. This doesn't fix everything, but let's merge what we're sure about already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially started in #18830
Subsequent PRs before this final one:
#18794
#18834
#18748