Skip to content

[SYCL] Return ref to shared_ptr from handler::getOrInsertHandlerKernelBundle() #18588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: sycl
Choose a base branch
from
Draft

[SYCL] Return ref to shared_ptr from handler::getOrInsertHandlerKernelBundle() #18588

wants to merge 10 commits into from

Conversation

Alexandr-Konovalov
Copy link
Contributor

It's reference to impl of handler, so it's correct to return the reference.

@Alexandr-Konovalov
[SYCL] Return ref to shared_ptr from handler::getOrInsertHandlerKerne…
af1880c 
…lBundle()

It's reference to impl of handler, so it's correct to return the
reference.

Signed-off-by: Alexandr Konovalov <[email protected]>
@Alexandr-Konovalov
Code formatting.
53b95a2 
Signed-off-by: Alexandr Konovalov <[email protected]>
Alexandr-Konovalov
Alexandr-Konovalov commented May 22, 2025
View reviewed changes
@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as ready for review May 22, 2025 14:39
@Alexandr-Konovalov Alexandr-Konovalov requested a review from a team as a code owner May 22, 2025 14:39
@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as draft May 23, 2025 13:07
@Alexandr-Konovalov
Copy link
Contributor Author

arc fails tracked by #18668

@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as ready for review May 26, 2025 16:13
@Alexandr-Konovalov
Copy link
Contributor Author

@uditagarwal97 , what do you think about it?

uditagarwal97
uditagarwal97 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

aelovikov-intel
aelovikov-intel requested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to think about this a bit.

aelovikov-intel
aelovikov-intel reviewed Jun 4, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this should be returning raw pointer with the kernel_bundle_impl updated to be inherited from std::enable_shared_from_this, similar to what I'm doing for other classes (e.g. #18795 with links in the description or current WIP #18767)

@Alexandr-Konovalov
Copy link
Contributor Author

IMO, this should be returning raw pointer with the kernel_bundle_impl updated to be inherited from std::enable_shared_from_this, similar to what I'm doing for other classes (e.g. #18795 with links in the description or current WIP #18767)

Thanks for the idea! [SYCL] enable_shared_from_this for kernel_bundle_impl #18899 opened.

@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as draft June 11, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel requested changes

@vinser52 vinser52 vinser52 approved these changes

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexandr-Konovalov @vinser52 @uditagarwal97 @aelovikov-intel