Skip to content

Add ISX031 gmsl support for Sensing sensor v6.12.34 Ubuntu 24.04 on ARL #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ijulipan wants to merge 5 commits into from
Closed

Add ISX031 gmsl support for Sensing sensor v6.12.34 Ubuntu 24.04 on ARL #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2138614
Add ISX031 gmsl support for Sensing sensor v6.12.34 Ubuntu 24.04 on ARL
ijulipan Oct 13, 2025
967d1d8
Modified code logic for FSIN GPIO
ijulipan Oct 14, 2025
85d614d
Remove unnecessary code block and set rest_gpio and fsin_gpio to ACTI…
ijulipan Oct 16, 2025
041a082
fixed mismatch gpio pin number
ijulipan Oct 16, 2025
fefc07e
Merge branch 'iotg_ipu6' into iotg_ipu6
ijulipan Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion drivers/media/i2c/isx031.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ struct isx031 {

struct isx031_platform_data *platform_data;
struct gpio_desc *reset_gpio;
struct gpio_desc *fsin_gpio;

/* Streaming on/off */
bool streaming;
Expand Down Expand Up @@ -904,7 +905,8 @@ static int isx031_probe(struct i2c_client *client)

isx031->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset",
GPIOD_OUT_LOW);

isx031->fsin_gpio = devm_gpiod_get_optional(&client->dev, "fsin",
GPIOD_OUT_LOW);
Comment on lines 906 to +909
Copy link

@123456987789 123456987789 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In isx031_resume, maybe also need set fsin_gpio.

Copy link
Author

@ijulipan ijulipan Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we tested this driver without adding in isx031_resume it was able to stream fine during our s3 and s4 PM stress test.

Copy link
Contributor

@hao-yao hao-yao Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frame_sync pin is low level effective?

if (IS_ERR(isx031->reset_gpio))
return -EPROBE_DEFER;
else if (isx031->reset_gpio == NULL)
Expand Down
3 changes: 3 additions & 0 deletions drivers/media/i2c/max9x/serdes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1859,12 +1859,15 @@ static int max9x_registered(struct v4l2_subdev *sd)
.table = {
GPIO_LOOKUP("", 0, "reset",
GPIO_ACTIVE_LOW),
GPIO_LOOKUP("", 7, "fsin",
GPIO_ACTIVE_LOW),
{}
},
};

sensor_gpios.dev_id = dev_id;
sensor_gpios.table[0].key = common->gpio_chip.label;
sensor_gpios.table[1].key = common->gpio_chip.label;

gpiod_add_lookup_table(&sensor_gpios);

Expand Down