Add ISX031 gmsl support for Sensing sensor v6.12.34 Ubuntu 24.04 on ARL #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijulipan
commented
Oct 13, 2025
ijulipan
commented
- Added new FSIN GPIO to enable frame sync
- Modified start/stop streaming with toggable FSIN GPIO
- Added new FSIN GPIO to enable frame sync - Modified start/stop streaming with toggable FSIN GPIO
123456987789
suggested changes
Nov 19, 2025
Comment on lines
906
to
+909
| isx031->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", | ||
| GPIOD_OUT_LOW); | ||
|
|
||
| isx031->fsin_gpio = devm_gpiod_get_optional(&client->dev, "fsin", | ||
| GPIOD_OUT_LOW); |
There was a problem hiding this comment.
In isx031_resume, maybe also need set fsin_gpio.
Author
There was a problem hiding this comment.
we tested this driver without adding in isx031_resume it was able to stream fine during our s3 and s4 PM stress test.
hao-yao
requested changes
Dec 3, 2025
Contributor
hao-yao
left a comment
hao-yao
left a comment
There was a problem hiding this comment.
Please rebase your commit onto the latest iotg_ipu6 branch and re-commit your changes, not back and forth.
drivers/media/i2c/isx031.c
Outdated
| /* Drive FSIN GPIO high to enable frame sync */ | ||
| if (isx031->fsin_gpio){ | ||
| gpiod_set_value_cansleep(isx031->fsin_gpio, 0); | ||
| usleep_range(300000, 500000); |
Contributor
There was a problem hiding this comment.
Why do we need such a long time? And please use msleep when need >20ms sleeping.
| isx031->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", | ||
| GPIOD_OUT_HIGH); | ||
| isx031->fsin_gpio = devm_gpiod_get_optional(&client->dev, "fsin", | ||
| GPIOD_OUT_LOW); |
Contributor
There was a problem hiding this comment.
The frame_sync pin is low level effective?
123456987789
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.