-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support older intel mac book pro with gcc 13 #1085
base: main
Are you sure you want to change the base?
Changes from 13 commits
00a4adb
5f4e039
1b14304
f02ed60
356fa1e
46b64bd
8f99e30
9087bfb
5fe2be0
aae9843
beb027b
aaee454
bfec292
4ff62db
cd05487
05b66db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
nezda marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1228,7 +1228,7 @@ class PaddingTransInterleaveCvt : protected xbyak::JitAvx512f { | |
jmp(ptr[reg_tmp + reg_tmp2 * sizeof(void*)], T_NEAR); // switch(rows-iterrow) ... | ||
align(sizeof(intptr_t)); | ||
L(l_tail_tbl); | ||
db(reinterpret_cast<uintptr_t>(nullptr), sizeof(intptr_t)); // case 0 should never occur | ||
db(nullptr, sizeof(intptr_t)); // case 0 should never occur | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copying your error msg
I actually want the first case. Can you try For curiosity, what is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, original code gcc rejected with above was db(reinterpret_cast<uintptr_t>(nullptr), sizeof(intptr_t)); // case 0 should never occur my wild guess "fix" that is committed in this branch atm db(nullptr, sizeof(intptr_t)); // case 0 should never occur you've just requested db(reinterpret_cast<uint64_t>(nullptr), sizeof(intptr_t)); // case 0 should never occur which seems to compile fine I re-confirmed the original doesn't compile with my gcc 13.2.0. I also confirmed I still get segfaults after re-building everything with this change. As for what |
||
for (int i = 1; i < trans_cell; ++i) putL(l_tail_case[i]); | ||
|
||
for (int m_tail = 1; m_tail < trans_cell; ++m_tail) { // case (m_tail): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @zhenwei-intel Can you check it and check if there are similar problems in other models? |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @intellinjun Can you check it and check if there are similar problems in other models? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the correction. I'm not familiar with docker but it seems that you are right. To be confirmed by @tylertitsworth?