Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/support older intel mac book pro with gcc 13 #1085

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Feature/support older intel mac book pro with gcc 13 #1085

wants to merge 16 commits into from

Commits on Dec 29, 2023

  1. Intel Mac's don't support [AMX](https://www.intel.com/content/www/us/… 

    …en/products/docs/accelerator-engines/what-is-intel-amx.html) anyway per intel#1081 (comment)

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    00a4adb View commit details
    Browse the repository at this point in the history

  2. gcc-13 said reinterpret_cast<uintptr_t>(nullptr) was ambiguous ¯\_(… 

    …ツ)_/¯

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5f4e039 View commit details
    Browse the repository at this point in the history

  3. fix docker command 

    Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1b14304 View commit details
    Browse the repository at this point in the history

  4. disable the build of qbits and the deprecated executor on darwin per i… 

    …ntel#1081 (comment)

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    f02ed60 View commit details
    Browse the repository at this point in the history

  5. attempting to address error : error: 'sysctlbyname' was not declared … 

    …in this scope; did you mean 'SYS_sysctlbyname'?

  ld: library not found for -lrt
  collect2: error: ld returned 1 exit status
  [2/164] Building CXX object models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o
  FAILED: models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o
  /usr/local/opt/gcc/bin/g++-13 -DNE_GELU_USE_VEC -DNE_SIMD_VEC_DOT_F16 -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/core/. -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas -O3 -DNDEBUG -std=c++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -fPIC -mf16c -mfma -mavx -mavx2 -fopenmp -MD -MT models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o -MF models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o.d -o models/mpt/CMakeFiles/mpt.dir/__/model_utils/util.cpp.o -c /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp
  /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp: In function 'int32_t get_num_physical_cores()':
  /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp:36:16: error: 'sysctlbyname' was not declared in this scope; did you mean 'SYS_sysctlbyname'?
     36 |   int result = sysctlbyname("hw.perflevel0.physicalcpu", &num_physical_cores, &len, NULL, 0);
        |                ^~~~~~~~~~~~
        |                SYS_sysctlbyname
  [3/164] Building CXX object models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o
  FAILED: models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o
  /usr/local/opt/gcc/bin/g++-13 -DNE_GELU_USE_VEC -DNE_SIMD_VEC_DOT_F16 -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/core/. -I/Users/nezda/code/itrex/intel_extension_for_transformers/llm/library/jblas -O3 -DNDEBUG -std=c++17 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.3.sdk -fPIC -mf16c -mfma -mavx -mavx2 -fopenmp -MD -MT models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o -MF models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o.d -o models/llama/CMakeFiles/llama.dir/__/model_utils/util.cpp.o -c /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp
  /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp: In function 'int32_t get_num_physical_cores()':
  /Users/nezda/code/itrex/intel_extension_for_transformers/llm/runtime/graph/models/model_utils/util.cpp:36:16: error: 'sysctlbyname' was not declared in this scope; did you mean 'SYS_sysctlbyname'?
     36 |   int result = sysctlbyname("hw.perflevel0.physicalcpu", &num_physical_cores, &len, NULL, 0);
        |                ^~~~~~~~~~~~
        |                SYS_sysctlbyname

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    356fa1e View commit details
    Browse the repository at this point in the history

  6. don't link to -rt for APPLE either per intel#1081 (reply in thread) 

    Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    46b64bd View commit details
    Browse the repository at this point in the history

  7. typos 

    Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    8f99e30 View commit details
    Browse the repository at this point in the history

  8. trying to make Intel mac work... (this didn't help?) 

    Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    9087bfb View commit details
    Browse the repository at this point in the history

  9. hacked requirements to strip "+cpu" suffix from torch==2.1.0 requirem… 

    …ents

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    5fe2be0 View commit details
    Browse the repository at this point in the history

  10. hacked requirements to strip "+cpu" suffix from torch==2.1.0 requirem… 

    …ents

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    aae9843 View commit details
    Browse the repository at this point in the history

  11. added missing rope_scale param 

    Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    beb027b View commit details
    Browse the repository at this point in the history

  12. attempt to deal with missing Linux-only os.sched_getaffinity for maco… 

    …s too

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    aaee454 View commit details
    Browse the repository at this point in the history

  13. I think f_norm_eps should be rms_norm_eps; guessed still missing ff… 

    …n_hidden_size, rope_scale, rope_theta

- tried to fix write_vocab_only but Params here missing lots too

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    bfec292 View commit details
    Browse the repository at this point in the history

  14. Update intel_extension_for_transformers/llm/runtime/graph/scripts/req… 

    …uirements/common.txt

Co-authored-by: Yi DING <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
    @nezda @DDEle
    nezda and DDEle committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    4ff62db View commit details
    Browse the repository at this point in the history

  15. on mac (darwin) strip "+cpu" suffix from torch==2.1.0 requirements 

    Co-authored-by: Yi DING <[email protected]>
Signed-off-by: Luke Nezda <[email protected]>
    @nezda @DDEle
    nezda and DDEle committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    cd05487 View commit details
    Browse the repository at this point in the history

  16. gcc-13 said reinterpret_cast<uintptr_t>(nullptr) was ambiguous ¯\_(… 

    …ツ)_/¯ - adjust per code review @DDEle

Signed-off-by: Luke Nezda <[email protected]>
    @nezda
    nezda committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    05b66db View commit details
    Browse the repository at this point in the history