Skip to content

update async-profiler to 4.0 for flame command #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/script/script_defs.go
Original file line number Diff line number Diff line change
Expand Up @@ -1280,7 +1280,7 @@ restore_settings() {
kill -0 $perf_dwarf_pid 2>/dev/null && kill -INT $perf_dwarf_pid
fi
for pid in "${java_pids[@]}"; do
async-profiler/profiler.sh stop -o collapsed "$pid"
async-profiler/bin/asprof stop -o collapsed "$pid"
done
}

Expand Down Expand Up @@ -1337,7 +1337,7 @@ fi
# Start Java profiling for each Java PID
for pid in "${java_pids[@]}"; do
java_cmds+=("$(tr '\000' ' ' < /proc/"$pid"/cmdline)")
async-profiler/profiler.sh start -i "$ap_interval" -o collapsed "$pid"
async-profiler/bin/asprof start -i "$ap_interval" -F probesp+vtable "$pid"
done

# Wait for the specified duration
Expand All @@ -1357,7 +1357,7 @@ fi

# Stop Java profiling, write output to ap_folded_<pid> files
for pid in "${java_pids[@]}"; do
async-profiler/profiler.sh stop -o collapsed -f ap_folded_"$pid" "$pid"
async-profiler/bin/asprof stop -o collapsed -f ap_folded_"$pid" "$pid"
done

# Wait for perf to finish
Expand Down
2 changes: 1 addition & 1 deletion tools/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ tools: async-profiler avx-turbo cpuid dmidecode ethtool fio ipmitool lshw lspci
cp linux_turbostat/tools/power/x86/turbostat/turbostat bin/
-cd bin && strip --strip-unneeded *

ASYNC_PROFILER_VERSION := "2.9"
ASYNC_PROFILER_VERSION := "4.0"
async-profiler:
ifeq ("$(wildcard async-profiler)","")
ifeq ("$(wildcard async-profiler-$(ASYNC_PROFILER_VERSION)-linux-x64.tar.gz)","")
Expand Down