Skip to content

update async-profiler to 4.0 for flame command #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

harp-intel
Copy link
Contributor

No description provided.

@harp-intel harp-intel requested a review from Copilot May 14, 2025 23:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the async-profiler commands to version 4.0 to support the flame command output.

  • Replaces calls to async-profiler/profiler.sh with async-profiler/bin/asprof for both start and stop commands
  • Adds an additional flag (-F probesp+vtable) when starting profiling to leverage new profiler behavior
Files not reviewed (1)
  • tools/Makefile: Language not supported
Comments suppressed due to low confidence (2)

internal/script/script_defs.go:1340

  • [nitpick] The introduction of the '-F probesp+vtable' flag requires verification against the async-profiler 4.0 documentation. Update documentation if needed to clarify its usage and ensure compatibility with existing workflows.
async-profiler/bin/asprof start -i "$ap_interval" -F probesp+vtable "$pid"

internal/script/script_defs.go:1360

  • [nitpick] Ensure that the updated stop command with file output (using 'asprof' instead of 'profiler.sh') correctly writes output to the specified file, and update any related documentation accordingly.
async-profiler/bin/asprof stop -o collapsed -f ap_folded_"$pid" "$pid"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant