Skip to content

fix(ui-many): fix imports of the multiversion support#2444

Merged
HerrTopi merged 1 commit intov12from
INSTUI-4953-v-12-double-check-all-components-to-make-sure-they-import-the-appropriate-components-internally
Mar 13, 2026
Merged

fix(ui-many): fix imports of the multiversion support#2444
HerrTopi merged 1 commit intov12from
INSTUI-4953-v-12-double-check-all-components-to-make-sure-they-import-the-appropriate-components-internally

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Mar 12, 2026 •
edited
Loading

INSTUI-4953

ISSUES:

  • the multiversion files do not always have the appropriate imports
  • @HerrTopi most of these changes involve v1 folders where the imports did not use any versioning and imports in props.ts

TEST:

  • check the changes, files in v1 folders should contains imports with v11_6
  • files in v2 folders should contains imports with latest
  • check the content of the changed /exports files (sometimes v1 and v2 versions are mixed here depending on the progress of the rework)
  • check the changed package.json files

@ToMESSKa ToMESSKa self-assigned this Mar 12, 2026
@github-actions
Copy link

github-actions bot commented Mar 12, 2026 •
edited
Loading

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-13 14:33 UTC

@ToMESSKa ToMESSKa force-pushed the INSTUI-4953-v-12-double-check-all-components-to-make-sure-they-import-the-appropriate-components-internally branch from cf21174 to 6663ce1 Compare March 12, 2026 13:20
ToMESSKa
ToMESSKa commented Mar 12, 2026
View reviewed changes
packages/ui-form-field/src/FormField/v1/index.tsx
Comment on lines 26 to -30

import { omitProps, pickProps } from '@instructure/ui-react-utils'

import { allowedProps as formFieldLayoutAllowedProps } from '../../FormFieldLayout/v2/props'

Copy link
Contributor Author

@ToMESSKa ToMESSKa Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FormField needed to be fixed. The v12 version only had a v1 of FormField, which was acutally the reworked version, see #2273 So I made that the v2 version and copied the files from master to v1.

ToMESSKa
ToMESSKa commented Mar 12, 2026
View reviewed changes
packages/ui-instructure/src/exports/b.ts
Comment on lines +1 to +7
/*
* The MIT License (MIT)
*
* Copyright (c) 2015 - present Instructure, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
Copy link
Contributor Author

@ToMESSKa ToMESSKa Mar 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AiInformation has a v2 version, but the export only had a a.ts files, so AiInformation was not accessible. So I created a b.ts file.

ToMESSKa
ToMESSKa commented Mar 12, 2026
View reviewed changes
packages/ui-color-picker/src/ColorContrast/v1/index.tsx
Comment on lines 119 to 121
<div css={styles?.statusIndicatorWrapper}>
<Pill color={pass ? 'success' : 'error'}>
<Pill color={pass ? 'success' : 'danger'}>
{pass ? successLabel : failureLabel}
Copy link
Contributor Author

@ToMESSKa ToMESSKa Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It threw some error so I fixed this. It is 'danger' on master https://github.com/instructure/instructure-ui/blob/master/packages/ui-color-picker/src/ColorContrast/index.tsx so this must have been an older version of the index file? This also in my ColorPicker rework. #2439

@ToMESSKa ToMESSKa requested review from HerrTopi and matyasf March 12, 2026 13:37
@ToMESSKa ToMESSKa mentioned this pull request Mar 12, 2026
Merged
matyasf
matyasf requested changes Mar 12, 2026
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when a component has just 1 vewrsion it needs always to refer to the /latestversion (is that right, @HerrTopi ?)

packages/ui-byline/src/Byline/v1/__tests__/Byline.test.tsx
import { Byline } from '../index'
import { BylineProps } from '../props'
import { runAxeCheck } from '@instructure/ui-axe-check'
import { View } from '@instructure/ui-view/latest'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Byline has just this version, we should use the /latest?

packages/ui-byline/src/Byline/v1/index.tsx
import { Component } from 'react'

import { omitProps } from '@instructure/ui-react-utils'
import { View } from '@instructure/ui-view/latest'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Byline has just this version, we should use the /latest?

packages/ui-color-picker/src/ColorContrast/v1/index.tsx
import { Pill } from '@instructure/ui-pill/latest'
import { Text } from '@instructure/ui-text/v11_6'
import { Heading } from '@instructure/ui-heading/v11_6'
import { Pill } from '@instructure/ui-pill/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-color-picker/src/ColorMixer/v1/ColorPalette/index.tsx
import { View } from '@instructure/ui-view/latest'
import type { ViewOwnProps } from '@instructure/ui-view/latest'
import { View } from '@instructure/ui-view/v11_6'
import type { ViewOwnProps } from '@instructure/ui-view/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-color-picker/src/ColorMixer/v1/RGBAInput/index.tsx

import { ScreenReaderContent } from '@instructure/ui-a11y-content'
import { TextInput } from '@instructure/ui-text-input/latest'
import { TextInput } from '@instructure/ui-text-input/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-date-input/src/DateInput2/v1/props.ts

import type { SyntheticEvent, InputHTMLAttributes } from 'react'
import type { FormMessage } from '@instructure/ui-form-field'
import type { FormMessage } from '@instructure/ui-form-field/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-date-time-input/src/DateTimeInput/v1/index.tsx
Comment on lines +28 to +35
import { FormFieldGroup } from '@instructure/ui-form-field/v11_6'
import type { FormMessage } from '@instructure/ui-form-field/v11_6'

import { DateInput } from '@instructure/ui-date-input/latest'
import { TimeSelect } from '@instructure/ui-time-select/latest'
import { Calendar } from '@instructure/ui-calendar/latest'
import { DateInput } from '@instructure/ui-date-input/v11_6'
import { TimeSelect } from '@instructure/ui-time-select/v11_6'
import { Calendar } from '@instructure/ui-calendar/v11_6'
import { AccessibleContent } from '@instructure/ui-a11y-content'
import { IconButton } from '@instructure/ui-buttons/latest'
import { IconButton } from '@instructure/ui-buttons/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-date-time-input/src/DateTimeInput/v1/props.ts

import { SyntheticEvent } from 'react'
import type { FormMessage } from '@instructure/ui-form-field'
import type { FormMessage } from '@instructure/ui-form-field/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-drilldown/src/Drilldown/v1/__tests__/Drilldown.test.tsx
import { runAxeCheck } from '@instructure/ui-axe-check'
import { IconCheckSolid } from '@instructure/ui-icons'
import { Popover } from '@instructure/ui-popover/latest'
import { Popover } from '@instructure/ui-popover/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version

packages/ui-drilldown/src/Drilldown/v1/DrilldownOption/props.ts
OptionsItemRenderProps,
OptionsItemProps
} from '@instructure/ui-options'
} from '@instructure/ui-options/v11_6'
Copy link
Collaborator

@matyasf matyasf Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be /latest because this has just one version (same for all other exports in Drilldown)

@balzss balzss self-requested a review March 13, 2026 09:39
@HerrTopi HerrTopi merged commit b61abe7 into v12 Mar 13, 2026
8 of 9 checks passed
@HerrTopi HerrTopi deleted the INSTUI-4953-v-12-double-check-all-components-to-make-sure-they-import-the-appropriate-components-internally branch March 13, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matyasf matyasf matyasf requested changes

@HerrTopi HerrTopi HerrTopi approved these changes

@balzss balzss Awaiting requested review from balzss

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ToMESSKa @matyasf @HerrTopi