Skip to content

[v12] feat(ui-side-nav-bar): rework SideNavBar new v12#2431

Merged
git-nandor merged 1 commit intov12from
INSTUI-4938_SideNavBar_rework_new_v12
Mar 12, 2026
Merged

[v12] feat(ui-side-nav-bar): rework SideNavBar new v12#2431
git-nandor merged 1 commit intov12from
INSTUI-4938_SideNavBar_rework_new_v12

Conversation

@git-nandor
Copy link
Contributor

INSTUI-4938

Summary

Migrated SideNavBar component from the old theming system.

Test plan

On the documentation page, verify that everything displays and works correctly.

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Mar 5, 2026
@git-nandor git-nandor marked this pull request as ready for review March 5, 2026 14:36
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-12 16:07 UTC

@git-nandor git-nandor changed the title feat(ui-side-nav-bar): rework SideNavBar feat(ui-side-nav-bar): rework SideNavBar new v12 Mar 5, 2026
@git-nandor git-nandor changed the title feat(ui-side-nav-bar): rework SideNavBar new v12 [v12] feat(ui-side-nav-bar): rework SideNavBar new v12 Mar 5, 2026
@git-nandor git-nandor force-pushed the INSTUI-4938_SideNavBar_rework_new_v12 branch from 22d10ac to 845e28a Compare March 9, 2026 08:47
@git-nandor git-nandor requested review from HerrTopi and removed request for joyenjoyer March 9, 2026 10:41
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👌

@git-nandor git-nandor force-pushed the INSTUI-4938_SideNavBar_rework_new_v12 branch 2 times, most recently from 7269332 to 6f39079 Compare March 11, 2026 14:38
Copy link
Contributor

@ToMESSKa ToMESSKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@git-nandor Can you take a look at the Badge please? Something is not right there. Maybe some import versioning issue? See #2444

@git-nandor git-nandor force-pushed the INSTUI-4938_SideNavBar_rework_new_v12 branch from 6f39079 to 6800a75 Compare March 12, 2026 15:32
@git-nandor
Copy link
Contributor Author

git-nandor commented Mar 12, 2026

@git-nandor Can you take a look at the Badge please? Something is not right there. Maybe some import versioning issue? See #2444

The issue was in the Badge component. The withStyle import was using the old, incorrect import pattern.

@git-nandor git-nandor requested a review from ToMESSKa March 12, 2026 15:50
@git-nandor git-nandor merged commit 0d959c8 into v12 Mar 12, 2026
8 of 9 checks passed
@git-nandor git-nandor deleted the INSTUI-4938_SideNavBar_rework_new_v12 branch March 12, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants