-
Notifications
You must be signed in to change notification settings - Fork 8
feat(deps): bump revm #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3fc30a4
3c32f6c
4ec5af7
7a4da88
aeb0092
7ef8de5
522654f
b25c897
cfab075
819dccb
6b7d78e
3bb20f0
093f9c2
9e47987
48c8616
8147b36
c204f44
f34bbc7
a0813ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,7 +83,7 @@ pub trait EvmExtUnchecked<Db: Database> { | |
let mut acct = self.account(address)?; | ||
let old = self.storage(address, index)?; | ||
|
||
let change = EvmStorageSlot::new_changed(old, value); | ||
let change = EvmStorageSlot::new_changed(old, value, 0); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is this new arg? how does it work? where is it used in revm? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for posterity: it is either a |
||
acct.storage.insert(index, change); | ||
acct.mark_touch(); | ||
|
||
|
@@ -171,11 +171,11 @@ pub trait EvmExtUnchecked<Db: Database> { | |
} | ||
} | ||
|
||
impl<Ctx, Insp, Inst, Prec> EvmExtUnchecked<Ctx::Db> for Evm<Ctx, Insp, Inst, Prec> | ||
impl<Ctx, Insp, Inst, Prec, Frame> EvmExtUnchecked<Ctx::Db> for Evm<Ctx, Insp, Inst, Prec, Frame> | ||
where | ||
Ctx: ContextTr, | ||
{ | ||
fn db_mut_ext(&mut self) -> &mut Ctx::Db { | ||
self.ctx.db() | ||
self.ctx.db_mut() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this revm feature removed?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was removed as a feature and it's now included by default—but only activated on the
Osaka
spec onwards. means we need to enable it/inject it ourselves wherever else we actually want to use the OpcodeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see bluealloy/revm#2601