feat(deps): bump revm #114
Conversation
Bumps to 26.0.1, with the necessary version bump
|
this appears to have changes that arent strictly a version bump |
| @@ -87,7 +87,6 @@ estimate_gas = ["optional_eip3607", "optional_no_base_fee", "dep:tracing"] | |||
| test-utils = ["revm/std", "revm/serde-json", "revm/alloydb"] | |||
|
|
|||
| secp256k1 = ["revm/secp256k1"] | |||
| secp256r1 = ["revm/secp256r1"] | |||
There was a problem hiding this comment.
was this revm feature removed?
There was a problem hiding this comment.
it was removed as a feature and it's now included by default—but only activated on the Osaka spec onwards. means we need to enable it/inject it ourselves wherever else we actually want to use the Opcode
|
on guidance from @bluealloy that equality will stay broken for a few weeks, let's re-write the tests and make a note |
|
revm bumped to equivalent version on paradigmxyz/reth#17153 |
| @@ -83,7 +83,7 @@ pub trait EvmExtUnchecked<Db: Database> { | |||
| let mut acct = self.account(address)?; | |||
| let old = self.storage(address, index)?; | |||
|
|
|||
| let change = EvmStorageSlot::new_changed(old, value); | |||
| let change = EvmStorageSlot::new_changed(old, value, 0); | |||
There was a problem hiding this comment.
what is this new arg? how does it work? where is it used in revm?
There was a problem hiding this comment.
for posterity: it is either a transaction_id and/or a transition_id (both terms are used in revm code) and the EVM internal journal uses it when reverting transitions while executing multiple transactions without commiting them to the db.
Bumps to 27.0.1, with the necessary version bump