Merged
Conversation
Merged
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
2 times, most recently
from
27f35cb to
2e97789
Compare
prestwich
commented
May 14, 2025
| // Calculate the time remaining in the current slot | ||
| let remaining = self.slot_calculator.calculate_timepoint_within_slot(unix_seconds); | ||
| // Deadline is equal to the start of the next slot plus the time remaining in this slot | ||
| Instant::now() + Duration::from_secs(remaining) |
Member
Author
There was a problem hiding this comment.
this seems to have been giving incorrect output. we need to sub remaining from duration, then add that to now
prestwich
commented
May 14, 2025
| time::{self, Duration}, | ||
| }; | ||
|
|
||
| /// Holds a bundle from the cache with a unique ID and a Zenith bundle. |
Member
Author
There was a problem hiding this comment.
replaced with sdk types
prestwich
commented
May 14, 2025
| /// # Arguments | ||
| /// | ||
| /// - finish_by: The deadline at which block simulation will end. | ||
| async fn next_block_env(&self, finish_by: Instant) -> eyre::Result<PecorinoBlockEnv> { |
Evalir
reviewed
May 14, 2025
Evalir
reviewed
May 15, 2025
Evalir
approved these changes
May 19, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
the code lgtm. Want to see @dylanlott 's testing results
prestwich
force-pushed
the
prestwich/cache-task
branch
from
9be8e0f to
e82c2cb
Compare
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
8099c79 to
9b4f4de
Compare
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
9b4f4de to
6bf80dd
Compare
prestwich
changed the base branch from
graphite-base/92
to
prestwich/sdk-signer-oauth
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
6bf80dd to
0ac3866
Compare
prestwich
force-pushed
the
prestwich/sdk-signer-oauth
branch
from
9bb3b73 to
d395f2e
Compare
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
0ac3866 to
a239bcb
Compare
dylanlott
approved these changes
May 23, 2025
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
a239bcb to
2fd44a7
Compare
prestwich
force-pushed
the
prestwich/sdk-signer-oauth
branch
from
d395f2e to
730dabd
Compare
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
2fd44a7 to
7c5a42c
Compare
prestwich
force-pushed
the
prestwich/sdk-signer-oauth
branch
from
730dabd to
485fc7b
Compare
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
6ba7761 to
924f6ef
Compare
prestwich
force-pushed
the
prestwich/env-cache-integration
branch
from
924f6ef to
d01eae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration for downstack PRs for cache and env tasks