Skip to content

Env Task #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Env Task #89

merged 1 commit into from
May 20, 2025

Conversation

@prestwich
Copy link
Member

@prestwich prestwich commented May 14, 2025 •
edited
Loading

Add the logic for EnvTask, which polls for new block headers, and then builds a Env using the latest header, and updates a watch channel

@prestwich Graphite App
Copy link
Member Author

prestwich commented May 14, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich marked this pull request as ready for review May 14, 2025 14:49
@prestwich prestwich changed the title refactor: continuing to clean Env Task May 14, 2025
@prestwich prestwich mentioned this pull request May 14, 2025
Merged
@prestwich prestwich changed the base branch from main to graphite-base/89 May 14, 2025 15:23
@prestwich prestwich changed the base branch from graphite-base/89 to prestwich/clean-sim-fut May 14, 2025 15:23
@prestwich prestwich mentioned this pull request May 14, 2025
Merged
@prestwich prestwich force-pushed the prestwich/env-task branch from 7a84ca9 to aaae56e Compare May 14, 2025 15:28
dylanlott
dylanlott requested changes May 14, 2025
View reviewed changes
Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stack this change on top of #86 since that was intended to prepare for these changes.

Base automatically changed from prestwich/clean-sim-fut to main May 14, 2025 15:33
@prestwich prestwich force-pushed the prestwich/env-task branch from aaae56e to 9aba860 Compare May 14, 2025 15:33
Evalir
Evalir approved these changes May 14, 2025
View reviewed changes
@prestwich prestwich changed the base branch from main to graphite-base/89 May 14, 2025 16:25
@prestwich prestwich force-pushed the prestwich/env-task branch from 9aba860 to 7e977d0 Compare May 14, 2025 16:25
@prestwich prestwich changed the base branch from graphite-base/89 to dylan/block-module May 14, 2025 16:25
This was referenced May 14, 2025
Merged
Merged
Base automatically changed from dylan/block-module to main May 14, 2025 16:42
@prestwich prestwich force-pushed the prestwich/env-task branch from 7e977d0 to 33a9d37 Compare May 14, 2025 16:51
@prestwich prestwich requested a review from dylanlott May 14, 2025 17:13
@prestwich prestwich force-pushed the prestwich/env-task branch from 4eac524 to 4cab472 Compare May 14, 2025 17:17
@prestwich prestwich mentioned this pull request May 14, 2025
Merged
@prestwich prestwich enabled auto-merge (squash) May 14, 2025 18:14
dylanlott
dylanlott approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev last night with my submit channel changes stacked on top. Functions as expected, approving to continue iterating.

@prestwich prestwich merged commit 4822c6f into main May 20, 2025
5 checks passed
@prestwich prestwich deleted the prestwich/env-task branch May 20, 2025 14:44
@prestwich prestwich mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanlott dylanlott dylanlott approved these changes

@Evalir Evalir Evalir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prestwich @dylanlott @Evalir