Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8846 - Tabs Vertical Tooltip #8886

Merged
merged 8 commits into from
Jul 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/components/tabs-vertical/example-index.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1>Vertical Tabs Test - Independent Scrolling</h1>
<div class="page-container no-scroll">

<!-- Vertical Tabs inside of a tab panel -->
<div id="tabs-vertical" class="vertical tab-container no-scroll is-personalizable" data-options='{ "verticalResponsive": true, "validate": false }'>
<div id="tabs-vertical" class="vertical tab-container no-scroll is-personalizable" data-options='{ "verticalResponsive": true, "validate": false, "moduleTabsTooltips": true }'>

<div class="tab-list-container scrollable-y">

Expand Down
3 changes: 2 additions & 1 deletion docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@
- `[Datagrid]` Added searched event for toolbar search. ([#8814](https://github.com/infor-design/enterprise/issues/8814))
- `[Datagrid]` Added setting `overrideTabbing` to disable tabbing sequence of datagrid which will allow custom tabbing from users. ([#8825](https://github.com/infor-design/enterprise/issues/8825))
- `[Weekview]` Added settings `showOvernightBothDays` and `overnightLabel` to customize overnight days. ([#8630](https://github.com/infor-design/enterprise/issues/8630))
- `[Switch]` Update switch design. ([#8852](https://github.com/infor-design/enterprise/issues/8852))
- `[Tabs Vertical]` Added settings `moduleTabsTooltips` available for tabs vertical to for showing tooltips. ([#8846](https://github.com/infor-design/enterprise/issues/8846))
- `[Tests]` Changed test framework to playwright. ([#8549](https://github.com/infor-design/enterprise-wc/issues/8549))
- `[Switch]` Update switch design. ([#8852](https://github.com/infor-design/enterprise/issues/8852))

## v4.97.0 Fixes

Expand Down
3 changes: 3 additions & 0 deletions src/components/tabs-vertical/_tabs-vertical.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
@include css3(user-select, none);
@include css3(touch-callout, none);

text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
color: $vertical-tab-text-color;
display: block;
font-size: $ids-size-font-base;
Expand Down
13 changes: 7 additions & 6 deletions src/components/tabs/tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -3466,11 +3466,7 @@ Tabs.prototype = {
this.adjustSpilloverNumber();
},

/**
* Checks cut off title for tabs.
* @private
* @returns {void}
*/
/* Checks cut off title for tabs */
checkCutOffTitle(tabs, visibleTabSize) {
if (tabs.is('a')) {
tabs = tabs.parent();
Expand Down Expand Up @@ -3508,7 +3504,12 @@ Tabs.prototype = {
cutoff = 'yes';
}

if (this.settings.maxWidth === null && prevWidth > (visibleTabSize - anchorPadding)) {
if (this.settings.maxWidth === null && prevWidth > (visibleTabSize - anchorPadding) && !this.element.hasClass('vertical')) {
cutoff = 'yes';
}

// Different Comparison for Vertical Tabs
if (this.settings.maxWidth === null && this.element.hasClass('vertical') && a[0].scrollWidth > a.innerWidth()) {
cutoff = 'yes';
}

Expand Down
Loading