-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8846 - Tabs Vertical Tooltip #8886
Conversation
…r showing tooltips
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjamesallen15 looks good. just one lint error to fix? Note im fixing some other test issues will merge soon
Yep will do shortly |
…abs-vertical-tooltip
…enterprise into 8846-tabs-vertical-tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James, this is already working as expected in New Version but not in Classic.
Notice that the first tab doesn't have ellipsis but has tooltip in Classic.
Test Data: screen-capture (2).webm
Thanks,
Janah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjamesallen15 seems @janahintal has a point on classic mode |
I didn't notice it. Will check it. Thanks @tmcconechy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the details for making this change. What existing problem does the pull request solve?
This pull request will add settings
moduleTabsTooltips
available for tabs vertical to for showing tooltips.Related github/jira issue (required):
Closes #8846
Steps necessary to review your pull request (required):
Included in this Pull Request: