8846 - Tabs Vertical Tooltip #8886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r showing tooltips
tmcconechy
previously approved these changes
Jul 10, 2024
There was a problem hiding this comment.
@tjamesallen15 looks good. just one lint error to fix? Note im fixing some other test issues will merge soon
Yep will do shortly |
tmcconechy
previously approved these changes
Jul 10, 2024
…abs-vertical-tooltip
…enterprise into 8846-tabs-vertical-tooltip
janahintal
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Hi James, this is already working as expected in New Version but not in Classic.
Notice that the first tab doesn't have ellipsis but has tooltip in Classic.
Test Data: screen-capture (2).webm
Thanks,
Janah
|
@tjamesallen15 seems @janahintal has a point on classic mode |
I didn't notice it. Will check it. Thanks @tmcconechy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
This pull request will add settings
moduleTabsTooltipsavailable for tabs vertical to for showing tooltips.Related github/jira issue (required):
Closes #8846
Steps necessary to review your pull request (required):
Included in this Pull Request: