Improve napari-imagej's Number/RealType support #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
commented
Oct 25, 2022
gselzer
force-pushed
the
126-ops-using-realtypes-dont-work-well-within-napari-imagej
branch
2 times, most recently
from
857d320 to
d3d9767
Compare
|
Alright, so this builds on my system, but that's using an unreleased pyimagej/imagej-common versions, and a scijava-common that isn't yet the default. So we'll need updates before this PR can be merged. |
gselzer
force-pushed
the
126-ops-using-realtypes-dont-work-well-within-napari-imagej
branch
2 times, most recently
from
a3730bf to
e1fec9a
Compare
gselzer
force-pushed
the
126-ops-using-realtypes-dont-work-well-within-napari-imagej
branch
from
e1fec9a to
f4e1691
Compare
gselzer
force-pushed
the
126-ops-using-realtypes-dont-work-well-within-napari-imagej
branch
from
f4e1691 to
853b3fb
Compare
gselzer
deleted the
126-ops-using-realtypes-dont-work-well-within-napari-imagej
branch
kephale
pushed a commit
to kephale/napari-imagej
that referenced
this pull request
May 24, 2023
…t-work-well-within-napari-imagej Improve napari-imagej's Number/RealType support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves support for
RealTypeI/OModuleparameters.Note that, because imagej-ops replaces these parameters with
Numbers, much of the work applies to bothRealTypes andNumbers.This PR relies on new releases of pyimagej and imagej-common, and would also benefit from a pom-scijava update to get the latest scijava-common version by default.