Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops using RealTypes don't work well within napari-imagej #126

Closed
gselzer opened this issue Oct 20, 2022 · 1 comment · Fixed by #128
Closed

Ops using RealTypes don't work well within napari-imagej #126

gselzer opened this issue Oct 20, 2022 · 1 comment · Fixed by #128
Assignees
@gselzer
Labels
bug Something isn't working
Milestone
0.1.0

Comments

@gselzer
Copy link
Collaborator

gselzer commented Oct 20, 2022

Running these Ops (and the commands wrapping them?) don't work very well. This is partially due to what I describe in imagej/imagej-ops#649, but it also is partially because napari-imagej's support for RealTypes could be improved.

Specifically, if I run the huMoment3 op, I have trouble getting the OpSearchResult to run the Op, and spoiler, once I get it to run the Op, the output won't display.
@gselzer gselzer self-assigned this Oct 20, 2022
@gselzer gselzer added this to the 0.1.0 milestone Oct 20, 2022
@gselzer gselzer added the bug Something isn't working label Oct 20, 2022
@gselzer
Copy link
Collaborator Author

gselzer commented Oct 25, 2022 •
edited
Loading

Okay, the good news is that with imagej/imagej-common#103 we don't need any Ops PRs to fix this!

@gselzer gselzer linked a pull request Oct 25, 2022 that will close this issue
Improve napari-imagej's Number/RealType support #128
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gselzer gselzer

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Improve napari-imagej's Number/RealType support imagej/napari-imagej
1 participant
@gselzer